UnitTests: Move symbolscollector data to sub directory

Change-Id: Id1a123f745a0f092aeff9589aa146feb49d31661
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This commit is contained in:
Marco Bubke
2019-02-07 12:20:39 +01:00
parent 24c7a51811
commit c52c531c3f
25 changed files with 300 additions and 174 deletions

View File

@@ -302,48 +302,83 @@ TEST_F(BuildDependencyCollector, TopIncludesIgnoreMissingFile)
TEST_F(BuildDependencyCollector, SourceFiles) TEST_F(BuildDependencyCollector, SourceFiles)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.collect(); emptyCollector.collect();
ASSERT_THAT(emptyCollector.sourceFiles(), ASSERT_THAT(emptyCollector.sourceFiles(),
UnorderedElementsAre(id(TESTDATA_DIR "/symbolscollector_main.cpp"), UnorderedElementsAre(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
id(TESTDATA_DIR "/symbolscollector_header1.h"), id(TESTDATA_DIR "/symbolscollector/header1.h"),
id(TESTDATA_DIR "/symbolscollector_header2.h"))); id(TESTDATA_DIR "/symbolscollector/header2.h")));
} }
TEST_F(BuildDependencyCollector, MainFileInSourceFiles) TEST_F(BuildDependencyCollector, MainFileInSourceFiles)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
ASSERT_THAT(emptyCollector.sourceFiles(), ASSERT_THAT(emptyCollector.sourceFiles(),
ElementsAre(id(TESTDATA_DIR "/symbolscollector_main.cpp"))); ElementsAre(id(TESTDATA_DIR "/symbolscollector/main.cpp")));
} }
TEST_F(BuildDependencyCollector, ResetMainFileInSourceFiles) TEST_F(BuildDependencyCollector, ResetMainFileInSourceFiles)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
ASSERT_THAT(emptyCollector.sourceFiles(), ASSERT_THAT(emptyCollector.sourceFiles(),
ElementsAre(id(TESTDATA_DIR "/symbolscollector_main.cpp"))); ElementsAre(id(TESTDATA_DIR "/symbolscollector/main.cpp")));
} }
TEST_F(BuildDependencyCollector, DontDuplicateSourceFiles) TEST_F(BuildDependencyCollector, DontDuplicateSourceFiles)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.collect(); emptyCollector.collect();
emptyCollector.collect(); emptyCollector.collect();
ASSERT_THAT(emptyCollector.sourceFiles(), ASSERT_THAT(emptyCollector.sourceFiles(),
UnorderedElementsAre(id(TESTDATA_DIR "/symbolscollector_main.cpp"), UnorderedElementsAre(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
id(TESTDATA_DIR "/symbolscollector_header1.h"), id(TESTDATA_DIR "/symbolscollector/header1.h"),
id(TESTDATA_DIR "/symbolscollector_header2.h"))); id(TESTDATA_DIR "/symbolscollector/header2.h")));
} }
TEST_F(BuildDependencyCollector, ClearSourceFiles) TEST_F(BuildDependencyCollector, ClearSourceFiles)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.clear(); emptyCollector.clear();
@@ -352,7 +387,14 @@ TEST_F(BuildDependencyCollector, ClearSourceFiles)
TEST_F(BuildDependencyCollector, ClearFileStatus) TEST_F(BuildDependencyCollector, ClearFileStatus)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.collect(); emptyCollector.collect();
emptyCollector.clear(); emptyCollector.clear();
@@ -362,7 +404,14 @@ TEST_F(BuildDependencyCollector, ClearFileStatus)
TEST_F(BuildDependencyCollector, ClearUsedMacros) TEST_F(BuildDependencyCollector, ClearUsedMacros)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_defines.h"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/defines.h"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.collect(); emptyCollector.collect();
emptyCollector.clear(); emptyCollector.clear();
@@ -372,7 +421,7 @@ TEST_F(BuildDependencyCollector, ClearUsedMacros)
TEST_F(BuildDependencyCollector, ClearSourceDependencies) TEST_F(BuildDependencyCollector, ClearSourceDependencies)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main2.cpp"), {"cc", "-I" TESTDATA_DIR}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main2.cpp"), {"cc", "-I" TESTDATA_DIR});
emptyCollector.collect(); emptyCollector.collect();
emptyCollector.clear(); emptyCollector.clear();
@@ -382,7 +431,14 @@ TEST_F(BuildDependencyCollector, ClearSourceDependencies)
TEST_F(BuildDependencyCollector, DontCollectSourceFilesAfterFilesAreCleared) TEST_F(BuildDependencyCollector, DontCollectSourceFilesAfterFilesAreCleared)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.clear(); emptyCollector.clear();
emptyCollector.collect(); emptyCollector.collect();
@@ -392,7 +448,14 @@ TEST_F(BuildDependencyCollector, DontCollectSourceFilesAfterFilesAreCleared)
TEST_F(BuildDependencyCollector, DontCollectFileStatusAfterFilesAreCleared) TEST_F(BuildDependencyCollector, DontCollectFileStatusAfterFilesAreCleared)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.clear(); emptyCollector.clear();
emptyCollector.collect(); emptyCollector.collect();
@@ -402,7 +465,14 @@ TEST_F(BuildDependencyCollector, DontCollectFileStatusAfterFilesAreCleared)
TEST_F(BuildDependencyCollector, DontCollectUsedMacrosAfterFilesAreCleared) TEST_F(BuildDependencyCollector, DontCollectUsedMacrosAfterFilesAreCleared)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.clear(); emptyCollector.clear();
emptyCollector.collect(); emptyCollector.collect();
@@ -413,7 +483,14 @@ TEST_F(BuildDependencyCollector, DontCollectUsedMacrosAfterFilesAreCleared)
TEST_F(BuildDependencyCollector, DontCollectSourceDependenciesAfterFilesAreCleared) TEST_F(BuildDependencyCollector, DontCollectSourceDependenciesAfterFilesAreCleared)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.clear(); emptyCollector.clear();
emptyCollector.collect(); emptyCollector.collect();
@@ -423,7 +500,7 @@ TEST_F(BuildDependencyCollector, DontCollectSourceDependenciesAfterFilesAreClear
TEST_F(BuildDependencyCollector, CollectUsedMacrosWithExternalDefine) TEST_F(BuildDependencyCollector, CollectUsedMacrosWithExternalDefine)
{ {
auto fileId = id(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = id(TESTDATA_DIR "/symbolscollector/defines.h");
emptyCollector.addFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); emptyCollector.addFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
emptyCollector.collect(); emptyCollector.collect();
@@ -438,8 +515,15 @@ TEST_F(BuildDependencyCollector, CollectUsedMacrosWithExternalDefine)
TEST_F(BuildDependencyCollector, CollectUsedMacrosWithoutExternalDefine) TEST_F(BuildDependencyCollector, CollectUsedMacrosWithoutExternalDefine)
{ {
auto fileId = id(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = id(TESTDATA_DIR "/symbolscollector/defines.h");
emptyCollector.addFile(fileId, {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(fileId,
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.collect(); emptyCollector.collect();
@@ -453,8 +537,15 @@ TEST_F(BuildDependencyCollector, CollectUsedMacrosWithoutExternalDefine)
TEST_F(BuildDependencyCollector, DontCollectHeaderGuards) TEST_F(BuildDependencyCollector, DontCollectHeaderGuards)
{ {
auto fileId = id(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = id(TESTDATA_DIR "/symbolscollector/defines.h");
emptyCollector.addFile(fileId, {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(fileId,
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.collect(); emptyCollector.collect();
@@ -464,8 +555,15 @@ TEST_F(BuildDependencyCollector, DontCollectHeaderGuards)
TEST_F(BuildDependencyCollector, DISABLED_DontCollectDynamicLibraryExports) TEST_F(BuildDependencyCollector, DISABLED_DontCollectDynamicLibraryExports)
{ {
auto fileId = id(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = id(TESTDATA_DIR "/symbolscollector/defines.h");
emptyCollector.addFile(fileId, {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(fileId,
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.collect(); emptyCollector.collect();
@@ -475,23 +573,29 @@ TEST_F(BuildDependencyCollector, DISABLED_DontCollectDynamicLibraryExports)
TEST_F(BuildDependencyCollector, CollectFileStatuses) TEST_F(BuildDependencyCollector, CollectFileStatuses)
{ {
emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc", "-I", TESTDATA_DIR "/builddependencycollector/external", "-I", TESTDATA_DIR "/builddependencycollector/project", "-isystem", TESTDATA_DIR "/builddependencycollector/system"}); emptyCollector.addFile(id(TESTDATA_DIR "/symbolscollector/main.cpp"),
{"cc",
"-I",
TESTDATA_DIR "/builddependencycollector/external",
"-I",
TESTDATA_DIR "/builddependencycollector/project",
"-isystem",
TESTDATA_DIR "/builddependencycollector/system"});
emptyCollector.collect(); emptyCollector.collect();
ASSERT_THAT(emptyCollector.fileStatuses(), ASSERT_THAT(emptyCollector.fileStatuses(),
ElementsAre( ElementsAre(fileStatus(TESTDATA_DIR "/symbolscollector/main.cpp"),
fileStatus(TESTDATA_DIR "/symbolscollector_main.cpp"), fileStatus(TESTDATA_DIR "/symbolscollector/header1.h"),
fileStatus(TESTDATA_DIR "/symbolscollector_header1.h"), fileStatus(TESTDATA_DIR "/symbolscollector/header2.h")));
fileStatus(TESTDATA_DIR "/symbolscollector_header2.h")));
} }
TEST_F(BuildDependencyCollector, CollectSourceDependencies) TEST_F(BuildDependencyCollector, CollectSourceDependencies)
{ {
auto mainFileId = id(TESTDATA_DIR "/symbolscollector_main2.cpp"); auto mainFileId = id(TESTDATA_DIR "/symbolscollector/main2.cpp");
auto header1FileId = id(TESTDATA_DIR "/symbolscollector_header1.h"); auto header1FileId = id(TESTDATA_DIR "/symbolscollector/header1.h");
auto header2FileId = id(TESTDATA_DIR "/symbolscollector_header2.h"); auto header2FileId = id(TESTDATA_DIR "/symbolscollector/header2.h");
auto header3FileId = id(TESTDATA_DIR "/symbolscollector_header3.h"); auto header3FileId = id(TESTDATA_DIR "/symbolscollector/header3.h");
emptyCollector.addFile(mainFileId, {"cc", "-I" TESTDATA_DIR}); emptyCollector.addFile(mainFileId, {"cc", "-I" TESTDATA_DIR});
emptyCollector.collect(); emptyCollector.collect();

View File

@@ -0,0 +1 @@
ERROR

View File

@@ -0,0 +1,3 @@
#pragma once
#include "header2.h"

View File

@@ -0,0 +1,3 @@
#pragma once
#include "header2.h"

View File

@@ -0,0 +1,4 @@
#include "header1.h"
void function();

View File

@@ -0,0 +1,5 @@
#include "header1.h"
#include "header3.h"
void function();

View File

@@ -1,4 +1,4 @@
#include <symbolscollector_unmodified_header.h> #include <unmodified_header.h>
#define MAINFILE_DEFINE #define MAINFILE_DEFINE

View File

@@ -1,4 +1,4 @@
#include <symbolscollector_unmodified_header.h> #include <unmodified_header.h>
#define MAINFILE_DEFINE #define MAINFILE_DEFINE

View File

@@ -0,0 +1,9 @@
#include <unmodified_header.h>
#include <unmodified_header2.h>
#define MAINFILE_DEFINE
void MainFileFunction()
{
HeaderFunctionReferenceInMainFile();
}

View File

@@ -0,0 +1 @@
#include "generated_file.h"

View File

@@ -1,3 +0,0 @@
#pragma once
#include "symbolscollector_header2.h"

View File

@@ -1,3 +0,0 @@
#pragma once
#include "symbolscollector_header2.h"

View File

@@ -1,4 +0,0 @@
#include "symbolscollector_header1.h"
void function();

View File

@@ -1,5 +0,0 @@
#include "symbolscollector_header1.h"
#include "symbolscollector_header3.h"
void function();

View File

@@ -1,9 +0,0 @@
#include <symbolscollector_unmodified_header.h>
#include <symbolscollector_unmodified_header2.h>
#define MAINFILE_DEFINE
void MainFileFunction()
{
HeaderFunctionReferenceInMainFile();
}

View File

@@ -1 +0,0 @@
#include "symbolscollector_generated_file.h"

View File

@@ -47,8 +47,7 @@ public:
ON_CALL(*this, setUnsavedFiles(_)).WillByDefault(Invoke(this, &MockSymbolsCollector::setHasUnsavedFiles)); ON_CALL(*this, setUnsavedFiles(_)).WillByDefault(Invoke(this, &MockSymbolsCollector::setHasUnsavedFiles));
} }
MOCK_METHOD0(collectSymbols, MOCK_METHOD0(collectSymbols, bool());
void());
MOCK_METHOD2(setFile, MOCK_METHOD2(setFile,
void(ClangBackEnd::FilePathId filePathId, void(ClangBackEnd::FilePathId filePathId,

View File

@@ -178,7 +178,7 @@ protected:
TEST_F(SymbolsCollector, CollectSymbolName) TEST_F(SymbolsCollector, CollectSymbolName)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_simple.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -188,7 +188,7 @@ TEST_F(SymbolsCollector, CollectSymbolName)
TEST_F(SymbolsCollector, SymbolMatchesLocation) TEST_F(SymbolsCollector, SymbolMatchesLocation)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_simple.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -200,7 +200,7 @@ TEST_F(SymbolsCollector, SymbolMatchesLocation)
TEST_F(SymbolsCollector, OtherSymboldMatchesLocation) TEST_F(SymbolsCollector, OtherSymboldMatchesLocation)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_simple.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -212,20 +212,19 @@ TEST_F(SymbolsCollector, OtherSymboldMatchesLocation)
TEST_F(SymbolsCollector, CollectFilePath) TEST_F(SymbolsCollector, CollectFilePath)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_simple.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
ASSERT_THAT(collector.sourceLocations(), ASSERT_THAT(collector.sourceLocations(),
Contains( Contains(AllOf(Field(&SourceLocationEntry::filePathId,
AllOf(Field(&SourceLocationEntry::filePathId, filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp")),
filePathId(TESTDATA_DIR"/symbolscollector_simple.cpp")), Field(&SourceLocationEntry::kind, SourceLocationKind::Declaration))));
Field(&SourceLocationEntry::kind, SourceLocationKind::Declaration))));
} }
TEST_F(SymbolsCollector, CollectLineColumn) TEST_F(SymbolsCollector, CollectLineColumn)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_simple.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -237,7 +236,7 @@ TEST_F(SymbolsCollector, CollectLineColumn)
TEST_F(SymbolsCollector, CollectReference) TEST_F(SymbolsCollector, CollectReference)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_simple.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -249,7 +248,7 @@ TEST_F(SymbolsCollector, CollectReference)
TEST_F(SymbolsCollector, ReferencedSymboldMatchesLocation) TEST_F(SymbolsCollector, ReferencedSymboldMatchesLocation)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_simple.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/simple.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -261,10 +260,9 @@ TEST_F(SymbolsCollector, ReferencedSymboldMatchesLocation)
TEST_F(SymbolsCollector, DISABLED_ON_WINDOWS(CollectInUnsavedFile)) TEST_F(SymbolsCollector, DISABLED_ON_WINDOWS(CollectInUnsavedFile))
{ {
FileContainers unsaved{{{TESTDATA_DIR, "symbolscollector_generated_file.h"}, FileContainers unsaved{
"void function();", {{TESTDATA_DIR, "symbolscollector/generated_file.h"}, "void function();", {}}};
{}}}; collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unsaved.cpp"), {"cc"});
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_unsaved.cpp"), {"cc"});
collector.setUnsavedFiles(std::move(unsaved)); collector.setUnsavedFiles(std::move(unsaved));
collector.collectSymbols(); collector.collectSymbols();
@@ -275,48 +273,48 @@ TEST_F(SymbolsCollector, DISABLED_ON_WINDOWS(CollectInUnsavedFile))
TEST_F(SymbolsCollector, SourceFiles) TEST_F(SymbolsCollector, SourceFiles)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
ASSERT_THAT(collector.sourceFiles(), ASSERT_THAT(collector.sourceFiles(),
UnorderedElementsAre(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), UnorderedElementsAre(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"),
filePathId(TESTDATA_DIR "/symbolscollector_header1.h"), filePathId(TESTDATA_DIR "/symbolscollector/header1.h"),
filePathId(TESTDATA_DIR "/symbolscollector_header2.h"))); filePathId(TESTDATA_DIR "/symbolscollector/header2.h")));
} }
TEST_F(SymbolsCollector, MainFileInSourceFiles) TEST_F(SymbolsCollector, MainFileInSourceFiles)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
ASSERT_THAT(collector.sourceFiles(), ASSERT_THAT(collector.sourceFiles(),
ElementsAre(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"))); ElementsAre(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp")));
} }
TEST_F(SymbolsCollector, ResetMainFileInSourceFiles) TEST_F(SymbolsCollector, ResetMainFileInSourceFiles)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
ASSERT_THAT(collector.sourceFiles(), ASSERT_THAT(collector.sourceFiles(),
ElementsAre(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"))); ElementsAre(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp")));
} }
TEST_F(SymbolsCollector, DontDuplicateSourceFiles) TEST_F(SymbolsCollector, DontDuplicateSourceFiles)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
collector.collectSymbols(); collector.collectSymbols();
ASSERT_THAT(collector.sourceFiles(), ASSERT_THAT(collector.sourceFiles(),
UnorderedElementsAre(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), UnorderedElementsAre(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"),
filePathId(TESTDATA_DIR "/symbolscollector_header1.h"), filePathId(TESTDATA_DIR "/symbolscollector/header1.h"),
filePathId(TESTDATA_DIR "/symbolscollector_header2.h"))); filePathId(TESTDATA_DIR "/symbolscollector/header2.h")));
} }
TEST_F(SymbolsCollector, ClearSourceFiles) TEST_F(SymbolsCollector, ClearSourceFiles)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
@@ -325,7 +323,7 @@ TEST_F(SymbolsCollector, ClearSourceFiles)
TEST_F(SymbolsCollector, ClearSymbols) TEST_F(SymbolsCollector, ClearSymbols)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
collector.clear(); collector.clear();
@@ -335,7 +333,7 @@ TEST_F(SymbolsCollector, ClearSymbols)
TEST_F(SymbolsCollector, ClearSourceLocations) TEST_F(SymbolsCollector, ClearSourceLocations)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
collector.clear(); collector.clear();
@@ -345,7 +343,7 @@ TEST_F(SymbolsCollector, ClearSourceLocations)
TEST_F(SymbolsCollector, ClearFileStatus) TEST_F(SymbolsCollector, ClearFileStatus)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
collector.clear(); collector.clear();
@@ -355,7 +353,7 @@ TEST_F(SymbolsCollector, ClearFileStatus)
TEST_F(SymbolsCollector, ClearUsedMacros) TEST_F(SymbolsCollector, ClearUsedMacros)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_defines.h"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/defines.h"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
collector.clear(); collector.clear();
@@ -365,7 +363,8 @@ TEST_F(SymbolsCollector, ClearUsedMacros)
TEST_F(SymbolsCollector, ClearSourceDependencies) TEST_F(SymbolsCollector, ClearSourceDependencies)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main2.cpp"), {"cc", "-I" TESTDATA_DIR}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main2.cpp"),
{"cc", "-I" TESTDATA_DIR});
collector.collectSymbols(); collector.collectSymbols();
collector.clear(); collector.clear();
@@ -375,7 +374,7 @@ TEST_F(SymbolsCollector, ClearSourceDependencies)
TEST_F(SymbolsCollector, DontCollectSymbolsAfterFilesAreCleared) TEST_F(SymbolsCollector, DontCollectSymbolsAfterFilesAreCleared)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
collector.collectSymbols(); collector.collectSymbols();
@@ -385,7 +384,7 @@ TEST_F(SymbolsCollector, DontCollectSymbolsAfterFilesAreCleared)
TEST_F(SymbolsCollector, DontCollectSourceFilesAfterFilesAreCleared) TEST_F(SymbolsCollector, DontCollectSourceFilesAfterFilesAreCleared)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
collector.collectSymbols(); collector.collectSymbols();
@@ -395,7 +394,7 @@ TEST_F(SymbolsCollector, DontCollectSourceFilesAfterFilesAreCleared)
TEST_F(SymbolsCollector, DontCollectFileStatusAfterFilesAreCleared) TEST_F(SymbolsCollector, DontCollectFileStatusAfterFilesAreCleared)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
collector.collectSymbols(); collector.collectSymbols();
@@ -405,7 +404,7 @@ TEST_F(SymbolsCollector, DontCollectFileStatusAfterFilesAreCleared)
TEST_F(SymbolsCollector, DontCollectUsedMacrosAfterFilesAreCleared) TEST_F(SymbolsCollector, DontCollectUsedMacrosAfterFilesAreCleared)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
collector.collectSymbols(); collector.collectSymbols();
@@ -415,7 +414,7 @@ TEST_F(SymbolsCollector, DontCollectUsedMacrosAfterFilesAreCleared)
TEST_F(SymbolsCollector, DontCollectSourceDependenciesAfterFilesAreCleared) TEST_F(SymbolsCollector, DontCollectSourceDependenciesAfterFilesAreCleared)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
collector.collectSymbols(); collector.collectSymbols();
@@ -425,7 +424,7 @@ TEST_F(SymbolsCollector, DontCollectSourceDependenciesAfterFilesAreCleared)
TEST_F(SymbolsCollector, CollectUsedMacrosWithExternalDefine) TEST_F(SymbolsCollector, CollectUsedMacrosWithExternalDefine)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -442,7 +441,7 @@ TEST_F(SymbolsCollector, CollectUsedMacrosWithExternalDefine)
TEST_F(SymbolsCollector, CollectUsedMacrosWithoutExternalDefine) TEST_F(SymbolsCollector, CollectUsedMacrosWithoutExternalDefine)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc"}); collector.setFile(fileId, {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -459,7 +458,7 @@ TEST_F(SymbolsCollector, CollectUsedMacrosWithoutExternalDefine)
TEST_F(SymbolsCollector, DontCollectHeaderGuards) TEST_F(SymbolsCollector, DontCollectHeaderGuards)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc"}); collector.setFile(fileId, {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -470,7 +469,7 @@ TEST_F(SymbolsCollector, DontCollectHeaderGuards)
TEST_F(SymbolsCollector, DISABLED_DontCollectDynamicLibraryExports) TEST_F(SymbolsCollector, DISABLED_DontCollectDynamicLibraryExports)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc"}); collector.setFile(fileId, {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -481,7 +480,7 @@ TEST_F(SymbolsCollector, DISABLED_DontCollectDynamicLibraryExports)
TEST_F(SymbolsCollector, CollectMacroDefinitionSourceLocation) TEST_F(SymbolsCollector, CollectMacroDefinitionSourceLocation)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -492,7 +491,7 @@ TEST_F(SymbolsCollector, CollectMacroDefinitionSourceLocation)
TEST_F(SymbolsCollector, CollectMacroUsageInIfNotDefSourceLocation) TEST_F(SymbolsCollector, CollectMacroUsageInIfNotDefSourceLocation)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -503,7 +502,7 @@ TEST_F(SymbolsCollector, CollectMacroUsageInIfNotDefSourceLocation)
TEST_F(SymbolsCollector, CollectSecondMacroUsageInIfNotDefSourceLocation) TEST_F(SymbolsCollector, CollectSecondMacroUsageInIfNotDefSourceLocation)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -514,7 +513,7 @@ TEST_F(SymbolsCollector, CollectSecondMacroUsageInIfNotDefSourceLocation)
TEST_F(SymbolsCollector, CollectMacroUsageCompilerArgumentSourceLocation) TEST_F(SymbolsCollector, CollectMacroUsageCompilerArgumentSourceLocation)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -525,7 +524,7 @@ TEST_F(SymbolsCollector, CollectMacroUsageCompilerArgumentSourceLocation)
TEST_F(SymbolsCollector, CollectMacroUsageInIfDefSourceLocation) TEST_F(SymbolsCollector, CollectMacroUsageInIfDefSourceLocation)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -536,7 +535,7 @@ TEST_F(SymbolsCollector, CollectMacroUsageInIfDefSourceLocation)
TEST_F(SymbolsCollector, CollectMacroUsageInDefinedSourceLocation) TEST_F(SymbolsCollector, CollectMacroUsageInDefinedSourceLocation)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -547,7 +546,7 @@ TEST_F(SymbolsCollector, CollectMacroUsageInDefinedSourceLocation)
TEST_F(SymbolsCollector, CollectMacroUsageExpansionSourceLocation) TEST_F(SymbolsCollector, CollectMacroUsageExpansionSourceLocation)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -558,7 +557,7 @@ TEST_F(SymbolsCollector, CollectMacroUsageExpansionSourceLocation)
TEST_F(SymbolsCollector, CollectMacroUsageUndefSourceLocation) TEST_F(SymbolsCollector, CollectMacroUsageUndefSourceLocation)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -569,7 +568,7 @@ TEST_F(SymbolsCollector, CollectMacroUsageUndefSourceLocation)
TEST_F(SymbolsCollector, CollectMacroUsageBuiltInSourceLocation) TEST_F(SymbolsCollector, CollectMacroUsageBuiltInSourceLocation)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -580,7 +579,7 @@ TEST_F(SymbolsCollector, CollectMacroUsageBuiltInSourceLocation)
TEST_F(SymbolsCollector, CollectMacroDefinitionSymbols) TEST_F(SymbolsCollector, CollectMacroDefinitionSymbols)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc"}); collector.setFile(fileId, {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -591,7 +590,7 @@ TEST_F(SymbolsCollector, CollectMacroDefinitionSymbols)
TEST_F(SymbolsCollector, CollectMacroBuiltInSymbols) TEST_F(SymbolsCollector, CollectMacroBuiltInSymbols)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc"}); collector.setFile(fileId, {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -602,7 +601,7 @@ TEST_F(SymbolsCollector, CollectMacroBuiltInSymbols)
TEST_F(SymbolsCollector, CollectMacroCompilerArgumentSymbols) TEST_F(SymbolsCollector, CollectMacroCompilerArgumentSymbols)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.setFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collectSymbols(); collector.collectSymbols();
@@ -613,24 +612,23 @@ TEST_F(SymbolsCollector, CollectMacroCompilerArgumentSymbols)
TEST_F(SymbolsCollector, CollectFileStatuses) TEST_F(SymbolsCollector, CollectFileStatuses)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/main.cpp");
collector.setFile(fileId, {"cc"}); collector.setFile(fileId, {"cc"});
collector.collectSymbols(); collector.collectSymbols();
ASSERT_THAT(collector.fileStatuses(), ASSERT_THAT(collector.fileStatuses(),
ElementsAre( ElementsAre(fileStatus(TESTDATA_DIR "/symbolscollector/main.cpp"),
fileStatus(TESTDATA_DIR "/symbolscollector_main.cpp"), fileStatus(TESTDATA_DIR "/symbolscollector/header1.h"),
fileStatus(TESTDATA_DIR "/symbolscollector_header1.h"), fileStatus(TESTDATA_DIR "/symbolscollector/header2.h")));
fileStatus(TESTDATA_DIR "/symbolscollector_header2.h")));
} }
TEST_F(SymbolsCollector, CollectSourceDependencies) TEST_F(SymbolsCollector, CollectSourceDependencies)
{ {
auto mainFileId = filePathId(TESTDATA_DIR "/symbolscollector_main2.cpp"); auto mainFileId = filePathId(TESTDATA_DIR "/symbolscollector/main2.cpp");
auto header1FileId = filePathId(TESTDATA_DIR "/symbolscollector_header1.h"); auto header1FileId = filePathId(TESTDATA_DIR "/symbolscollector/header1.h");
auto header2FileId = filePathId(TESTDATA_DIR "/symbolscollector_header2.h"); auto header2FileId = filePathId(TESTDATA_DIR "/symbolscollector/header2.h");
auto header3FileId = filePathId(TESTDATA_DIR "/symbolscollector_header3.h"); auto header3FileId = filePathId(TESTDATA_DIR "/symbolscollector/header3.h");
collector.setFile(mainFileId, {"cc", "-I" TESTDATA_DIR}); collector.setFile(mainFileId, {"cc", "-I" TESTDATA_DIR});
collector.collectSymbols(); collector.collectSymbols();
@@ -644,7 +642,7 @@ TEST_F(SymbolsCollector, CollectSourceDependencies)
TEST_F(SymbolsCollector, IsClassSymbol) TEST_F(SymbolsCollector, IsClassSymbol)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_symbolkind.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -658,7 +656,7 @@ TEST_F(SymbolsCollector, IsClassSymbol)
TEST_F(SymbolsCollector, IsStructSymbol) TEST_F(SymbolsCollector, IsStructSymbol)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_symbolkind.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -672,7 +670,7 @@ TEST_F(SymbolsCollector, IsStructSymbol)
TEST_F(SymbolsCollector, IsEnumerationSymbol) TEST_F(SymbolsCollector, IsEnumerationSymbol)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_symbolkind.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -690,7 +688,7 @@ TEST_F(SymbolsCollector, IsEnumerationSymbol)
TEST_F(SymbolsCollector, IsUnionSymbol) TEST_F(SymbolsCollector, IsUnionSymbol)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_symbolkind.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -704,7 +702,7 @@ TEST_F(SymbolsCollector, IsUnionSymbol)
TEST_F(SymbolsCollector, DISABLED_ON_NON_WINDOWS(IsMsvcInterfaceSymbol)) TEST_F(SymbolsCollector, DISABLED_ON_NON_WINDOWS(IsMsvcInterfaceSymbol))
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_symbolkind.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -718,7 +716,7 @@ TEST_F(SymbolsCollector, DISABLED_ON_NON_WINDOWS(IsMsvcInterfaceSymbol))
TEST_F(SymbolsCollector, IsFunctionSymbol) TEST_F(SymbolsCollector, IsFunctionSymbol)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_symbolkind.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -731,7 +729,7 @@ TEST_F(SymbolsCollector, IsFunctionSymbol)
TEST_F(SymbolsCollector, IsVariableSymbol) TEST_F(SymbolsCollector, IsVariableSymbol)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_symbolkind.cpp"), {"cc"}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/symbolkind.cpp"), {"cc"});
collector.collectSymbols(); collector.collectSymbols();
@@ -744,7 +742,8 @@ TEST_F(SymbolsCollector, IsVariableSymbol)
TEST_F(SymbolsCollector, IndexUnmodifiedHeaderFilesAtFirstRun) TEST_F(SymbolsCollector, IndexUnmodifiedHeaderFilesAtFirstRun)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_unmodified.cpp"), {"cc", "-I", {TESTDATA_DIR, "/include"}}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
collector.collectSymbols(); collector.collectSymbols();
@@ -761,10 +760,12 @@ TEST_F(SymbolsCollector, IndexUnmodifiedHeaderFilesAtFirstRun)
TEST_F(SymbolsCollector, DontIndexUnmodifiedHeaderFilesAtSecondRun) TEST_F(SymbolsCollector, DontIndexUnmodifiedHeaderFilesAtSecondRun)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_unmodified.cpp"), {"cc", "-I", {TESTDATA_DIR, "/include"}}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
collector.collectSymbols(); collector.collectSymbols();
collector.clear(); collector.clear();
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_unmodified2.cpp"), {"cc", "-I", {TESTDATA_DIR, "/include"}}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified2.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
collector.collectSymbols(); collector.collectSymbols();
@@ -780,11 +781,13 @@ TEST_F(SymbolsCollector, DontIndexUnmodifiedHeaderFilesAtSecondRun)
TEST_F(SymbolsCollector, DontIndexUnmodifiedHeaderFilesAtTouchHeader) TEST_F(SymbolsCollector, DontIndexUnmodifiedHeaderFilesAtTouchHeader)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_unmodified3.cpp"), {"cc", "-I", {TESTDATA_DIR, "/include"}}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified3.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
collector.collectSymbols(); collector.collectSymbols();
collector.clear(); collector.clear();
touchFile(TESTDATA_DIR "/include/symbolscollector_unmodified_header2.h"); touchFile(TESTDATA_DIR "/symbolscollector/include/unmodified_header2.h");
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_unmodified3.cpp"), {"cc", "-I", {TESTDATA_DIR, "/include"}}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified3.cpp"),
{"cc", "-I", {TESTDATA_DIR, "/symbolscollector/include"}});
collector.collectSymbols(); collector.collectSymbols();
@@ -800,7 +803,8 @@ TEST_F(SymbolsCollector, DontIndexUnmodifiedHeaderFilesAtTouchHeader)
TEST_F(SymbolsCollector, DontIndexSystemIncudes) TEST_F(SymbolsCollector, DontIndexSystemIncudes)
{ {
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector_unmodified.cpp"), {"cc", "-isystem", {TESTDATA_DIR, "/include"}}); collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/unmodified.cpp"),
{"cc", "-isystem", {TESTDATA_DIR, "/symbolscollector/include"}});
collector.collectSymbols(); collector.collectSymbols();
@@ -815,4 +819,22 @@ TEST_F(SymbolsCollector, DontIndexSystemIncudes)
Not(Contains(HasSymbolName("HEADER_DEFINE"))), Not(Contains(HasSymbolName("HEADER_DEFINE"))),
Not(Contains(HasSymbolName("FunctionLocalVariable"))))); Not(Contains(HasSymbolName("FunctionLocalVariable")))));
} }
TEST_F(SymbolsCollector, CollectReturnsFalseIfThereIsError)
{
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/error.cpp"), {"cc"});
bool success = collector.collectSymbols();
ASSERT_FALSE(success);
} }
TEST_F(SymbolsCollector, CollectReturnsFalseIfThereIsNoError)
{
collector.setFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
bool success = collector.collectSymbols();
ASSERT_TRUE(success);
}
} // namespace

View File

@@ -79,48 +79,48 @@ protected:
TEST_F(UsedMacroAndSourcesCollector, SourceFiles) TEST_F(UsedMacroAndSourcesCollector, SourceFiles)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collect(); collector.collect();
ASSERT_THAT(collector.sourceFiles(), ASSERT_THAT(collector.sourceFiles(),
UnorderedElementsAre(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), UnorderedElementsAre(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"),
filePathId(TESTDATA_DIR "/symbolscollector_header1.h"), filePathId(TESTDATA_DIR "/symbolscollector/header1.h"),
filePathId(TESTDATA_DIR "/symbolscollector_header2.h"))); filePathId(TESTDATA_DIR "/symbolscollector/header2.h")));
} }
TEST_F(UsedMacroAndSourcesCollector, MainFileInSourceFiles) TEST_F(UsedMacroAndSourcesCollector, MainFileInSourceFiles)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
ASSERT_THAT(collector.sourceFiles(), ASSERT_THAT(collector.sourceFiles(),
ElementsAre(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"))); ElementsAre(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp")));
} }
TEST_F(UsedMacroAndSourcesCollector, ResetMainFileInSourceFiles) TEST_F(UsedMacroAndSourcesCollector, ResetMainFileInSourceFiles)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
ASSERT_THAT(collector.sourceFiles(), ASSERT_THAT(collector.sourceFiles(),
ElementsAre(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"))); ElementsAre(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp")));
} }
TEST_F(UsedMacroAndSourcesCollector, DontDuplicateSourceFiles) TEST_F(UsedMacroAndSourcesCollector, DontDuplicateSourceFiles)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collect(); collector.collect();
collector.collect(); collector.collect();
ASSERT_THAT(collector.sourceFiles(), ASSERT_THAT(collector.sourceFiles(),
UnorderedElementsAre(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), UnorderedElementsAre(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"),
filePathId(TESTDATA_DIR "/symbolscollector_header1.h"), filePathId(TESTDATA_DIR "/symbolscollector/header1.h"),
filePathId(TESTDATA_DIR "/symbolscollector_header2.h"))); filePathId(TESTDATA_DIR "/symbolscollector/header2.h")));
} }
TEST_F(UsedMacroAndSourcesCollector, ClearSourceFiles) TEST_F(UsedMacroAndSourcesCollector, ClearSourceFiles)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
@@ -129,7 +129,7 @@ TEST_F(UsedMacroAndSourcesCollector, ClearSourceFiles)
TEST_F(UsedMacroAndSourcesCollector, ClearFileStatus) TEST_F(UsedMacroAndSourcesCollector, ClearFileStatus)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collect(); collector.collect();
collector.clear(); collector.clear();
@@ -139,7 +139,7 @@ TEST_F(UsedMacroAndSourcesCollector, ClearFileStatus)
TEST_F(UsedMacroAndSourcesCollector, ClearUsedMacros) TEST_F(UsedMacroAndSourcesCollector, ClearUsedMacros)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_defines.h"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/defines.h"), {"cc"});
collector.collect(); collector.collect();
collector.clear(); collector.clear();
@@ -149,7 +149,7 @@ TEST_F(UsedMacroAndSourcesCollector, ClearUsedMacros)
TEST_F(UsedMacroAndSourcesCollector, ClearSourceDependencies) TEST_F(UsedMacroAndSourcesCollector, ClearSourceDependencies)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main2.cpp"), {"cc", "-I" TESTDATA_DIR}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main2.cpp"), {"cc", "-I" TESTDATA_DIR});
collector.collect(); collector.collect();
collector.clear(); collector.clear();
@@ -159,7 +159,7 @@ TEST_F(UsedMacroAndSourcesCollector, ClearSourceDependencies)
TEST_F(UsedMacroAndSourcesCollector, DontCollectSourceFilesAfterFilesAreCleared) TEST_F(UsedMacroAndSourcesCollector, DontCollectSourceFilesAfterFilesAreCleared)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
collector.collect(); collector.collect();
@@ -169,7 +169,7 @@ TEST_F(UsedMacroAndSourcesCollector, DontCollectSourceFilesAfterFilesAreCleared)
TEST_F(UsedMacroAndSourcesCollector, DontCollectFileStatusAfterFilesAreCleared) TEST_F(UsedMacroAndSourcesCollector, DontCollectFileStatusAfterFilesAreCleared)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
collector.collect(); collector.collect();
@@ -179,7 +179,7 @@ TEST_F(UsedMacroAndSourcesCollector, DontCollectFileStatusAfterFilesAreCleared)
TEST_F(UsedMacroAndSourcesCollector, DontCollectUsedMacrosAfterFilesAreCleared) TEST_F(UsedMacroAndSourcesCollector, DontCollectUsedMacrosAfterFilesAreCleared)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
collector.collect(); collector.collect();
@@ -190,7 +190,7 @@ TEST_F(UsedMacroAndSourcesCollector, DontCollectUsedMacrosAfterFilesAreCleared)
TEST_F(UsedMacroAndSourcesCollector, DontCollectSourceDependenciesAfterFilesAreCleared) TEST_F(UsedMacroAndSourcesCollector, DontCollectSourceDependenciesAfterFilesAreCleared)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.clear(); collector.clear();
collector.collect(); collector.collect();
@@ -200,7 +200,7 @@ TEST_F(UsedMacroAndSourcesCollector, DontCollectSourceDependenciesAfterFilesAreC
TEST_F(UsedMacroAndSourcesCollector, CollectUsedMacrosWithExternalDefine) TEST_F(UsedMacroAndSourcesCollector, CollectUsedMacrosWithExternalDefine)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.addFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"}); collector.addFile(fileId, {"cc", "-DCOMPILER_ARGUMENT"});
collector.collect(); collector.collect();
@@ -217,7 +217,7 @@ TEST_F(UsedMacroAndSourcesCollector, CollectUsedMacrosWithExternalDefine)
TEST_F(UsedMacroAndSourcesCollector, CollectUsedMacrosWithoutExternalDefine) TEST_F(UsedMacroAndSourcesCollector, CollectUsedMacrosWithoutExternalDefine)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.addFile(fileId, {"cc"}); collector.addFile(fileId, {"cc"});
collector.collect(); collector.collect();
@@ -234,7 +234,7 @@ TEST_F(UsedMacroAndSourcesCollector, CollectUsedMacrosWithoutExternalDefine)
TEST_F(UsedMacroAndSourcesCollector, DontCollectHeaderGuards) TEST_F(UsedMacroAndSourcesCollector, DontCollectHeaderGuards)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.addFile(fileId, {"cc"}); collector.addFile(fileId, {"cc"});
collector.collect(); collector.collect();
@@ -245,7 +245,7 @@ TEST_F(UsedMacroAndSourcesCollector, DontCollectHeaderGuards)
TEST_F(UsedMacroAndSourcesCollector, DISABLED_DontCollectDynamicLibraryExports) TEST_F(UsedMacroAndSourcesCollector, DISABLED_DontCollectDynamicLibraryExports)
{ {
auto fileId = filePathId(TESTDATA_DIR "/symbolscollector_defines.h"); auto fileId = filePathId(TESTDATA_DIR "/symbolscollector/defines.h");
collector.addFile(fileId, {"cc"}); collector.addFile(fileId, {"cc"});
collector.collect(); collector.collect();
@@ -256,23 +256,23 @@ TEST_F(UsedMacroAndSourcesCollector, DISABLED_DontCollectDynamicLibraryExports)
TEST_F(UsedMacroAndSourcesCollector, CollectFileStatuses) TEST_F(UsedMacroAndSourcesCollector, CollectFileStatuses)
{ {
collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector_main.cpp"), {"cc"}); collector.addFile(filePathId(TESTDATA_DIR "/symbolscollector/main.cpp"), {"cc"});
collector.collect(); collector.collect();
ASSERT_THAT(collector.fileStatuses(), ASSERT_THAT(collector.fileStatuses(),
ElementsAre( ElementsAre(
fileStatus(TESTDATA_DIR "/symbolscollector_main.cpp"), fileStatus(TESTDATA_DIR "/symbolscollector/main.cpp"),
fileStatus(TESTDATA_DIR "/symbolscollector_header1.h"), fileStatus(TESTDATA_DIR "/symbolscollector/header1.h"),
fileStatus(TESTDATA_DIR "/symbolscollector_header2.h"))); fileStatus(TESTDATA_DIR "/symbolscollector/header2.h")));
} }
TEST_F(UsedMacroAndSourcesCollector, CollectSourceDependencies) TEST_F(UsedMacroAndSourcesCollector, CollectSourceDependencies)
{ {
auto mainFileId = filePathId(TESTDATA_DIR "/symbolscollector_main2.cpp"); auto mainFileId = filePathId(TESTDATA_DIR "/symbolscollector/main2.cpp");
auto header1FileId = filePathId(TESTDATA_DIR "/symbolscollector_header1.h"); auto header1FileId = filePathId(TESTDATA_DIR "/symbolscollector/header1.h");
auto header2FileId = filePathId(TESTDATA_DIR "/symbolscollector_header2.h"); auto header2FileId = filePathId(TESTDATA_DIR "/symbolscollector/header2.h");
auto header3FileId = filePathId(TESTDATA_DIR "/symbolscollector_header3.h"); auto header3FileId = filePathId(TESTDATA_DIR "/symbolscollector/header3.h");
collector.addFile(mainFileId, {"cc", "-I" TESTDATA_DIR}); collector.addFile(mainFileId, {"cc", "-I" TESTDATA_DIR});
collector.collect(); collector.collect();