feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CrashHandler: Fix missing update

Browse Source 
The change to CheckableMessageBox was missed.

Change-Id: I8b7fe1230bcf483f9e5371b878d862aff422d925
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Marcus Tillmanns
2023-05-17 10:30:20 +02:00
parent 8f5703a7b9
commit c59f3102a1
1 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/tools/qtcreatorcrashhandler/crashhandlerdialog.cpp
View File

@@ -205,12 +205,10 @@ CrashHandlerDialog::~CrashHandlerDialog()
bool CrashHandlerDialog::runDebuggerWhileBacktraceNotFinished() bool CrashHandlerDialog::runDebuggerWhileBacktraceNotFinished()
{ {
// Check settings. // Check settings.
QSettings settings(QSettings::IniFormat, QSettings::UserScope, QSettings settings(QSettings::IniFormat,
QSettings::UserScope,
QLatin1String(Core::Constants::IDE_SETTINGSVARIANT_STR), QLatin1String(Core::Constants::IDE_SETTINGSVARIANT_STR),
QLatin1String(SettingsApplication)); QLatin1String(SettingsApplication));
if (settings.value(QLatin1String(SettingsKeySkipWarningAbortingBacktrace), false).toBool())
return true;
// Ask user. // Ask user.
const QString title = tr("Run Debugger And Abort Collecting Backtrace?"); const QString title = tr("Run Debugger And Abort Collecting Backtrace?");
const QString message = tr( const QString message = tr(
@@ -219,15 +217,18 @@ bool CrashHandlerDialog::runDebuggerWhileBacktraceNotFinished()
"<p>You have requested to run the debugger while collecting the backtrace was not " "<p>You have requested to run the debugger while collecting the backtrace was not "
"finished.</p>" "finished.</p>"
"</body></html>"); "</body></html>");
const QString checkBoxText = tr("Do not &ask again.");
bool checkBoxSetting = false;
const QDialogButtonBox::StandardButton button = Utils::CheckableMessageBox::question(this,
title, message, checkBoxText, &checkBoxSetting,
QDialogButtonBox::Yes | QDialogButtonBox::No, QDialogButtonBox::No);
if (checkBoxSetting)
settings.setValue(QLatin1String(SettingsKeySkipWarningAbortingBacktrace), checkBoxSetting);
return button == QDialogButtonBox::Yes; const QMessageBox::StandardButton button
= Utils::CheckableMessageBox::question(this,
title,
message,
&settings,
QLatin1String(
SettingsKeySkipWarningAbortingBacktrace),
QMessageBox::Yes | QMessageBox::No,
QMessageBox::No);
return button == QMessageBox::Yes;
} }
void CrashHandlerDialog::setToFinalState() void CrashHandlerDialog::setToFinalState()