feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppTools: Tests: Allow to check only project relevant state

Browse Source 
Needed for ClangCodeModel.

If editors are open, the global snapshot and working copy will not be
empty.

Change-Id: I0d1bab8e082a7f41630c7b1b78febe2da009298b
Reviewed-by: Marco Bubke <marco.bubke@theqtcompany.com>
This commit is contained in:
Nikolai Kosjar
2015-05-08 12:19:08 +02:00
parent 9425812066
commit c5c57dca0c
4 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/cpptools/cpptoolstestcase.cpp
View File

@@ -363,16 +363,18 @@ VerifyCleanCppModelManager::~VerifyCleanCppModelManager() {
#define RETURN_FALSE_IF_NOT(check) if (!(check)) return false; #define RETURN_FALSE_IF_NOT(check) if (!(check)) return false;
bool VerifyCleanCppModelManager::isClean() bool VerifyCleanCppModelManager::isClean(bool testOnlyForCleanedProjects)
{ {
CppModelManager *mm = CppModelManager::instance(); CppModelManager *mm = CppModelManager::instance();
RETURN_FALSE_IF_NOT(mm->projectInfos().isEmpty()); RETURN_FALSE_IF_NOT(mm->projectInfos().isEmpty());
RETURN_FALSE_IF_NOT(mm->headerPaths().isEmpty()); RETURN_FALSE_IF_NOT(mm->headerPaths().isEmpty());
RETURN_FALSE_IF_NOT(mm->definedMacros().isEmpty()); RETURN_FALSE_IF_NOT(mm->definedMacros().isEmpty());
RETURN_FALSE_IF_NOT(mm->projectFiles().isEmpty()); RETURN_FALSE_IF_NOT(mm->projectFiles().isEmpty());
RETURN_FALSE_IF_NOT(mm->snapshot().isEmpty()); if (!testOnlyForCleanedProjects) {
RETURN_FALSE_IF_NOT(mm->workingCopy().size() == 1); RETURN_FALSE_IF_NOT(mm->snapshot().isEmpty());
RETURN_FALSE_IF_NOT(mm->workingCopy().contains(mm->configurationFileName())); RETURN_FALSE_IF_NOT(mm->workingCopy().size() == 1);
RETURN_FALSE_IF_NOT(mm->workingCopy().contains(mm->configurationFileName()));
}
return true; return true;
} }

2
src/plugins/cpptools/cpptoolstestcase.h
View File

@@ -161,7 +161,7 @@ class CPPTOOLS_EXPORT VerifyCleanCppModelManager
public: public:
VerifyCleanCppModelManager(); VerifyCleanCppModelManager();
~VerifyCleanCppModelManager(); ~VerifyCleanCppModelManager();
static bool isClean(); static bool isClean(bool testCleanedProjects = true);
}; };
class FileWriterAndRemover class FileWriterAndRemover

10
src/plugins/cpptools/modelmanagertesthelper.cpp
View File

@@ -54,8 +54,10 @@ TestProject::~TestProject()
{ {
} }
ModelManagerTestHelper::ModelManagerTestHelper(QObject *parent) : ModelManagerTestHelper::ModelManagerTestHelper(QObject *parent,
QObject(parent) bool testOnlyForCleanedProjects)
: QObject(parent)
, m_testOnlyForCleanedProjects(testOnlyForCleanedProjects)
{ {
CppModelManager *mm = CppModelManager::instance(); CppModelManager *mm = CppModelManager::instance();
@@ -69,13 +71,13 @@ ModelManagerTestHelper::ModelManagerTestHelper(QObject *parent) :
this, &ModelManagerTestHelper::gcFinished); this, &ModelManagerTestHelper::gcFinished);
cleanup(); cleanup();
QVERIFY(Tests::VerifyCleanCppModelManager::isClean()); QVERIFY(Tests::VerifyCleanCppModelManager::isClean(m_testOnlyForCleanedProjects));
} }
ModelManagerTestHelper::~ModelManagerTestHelper() ModelManagerTestHelper::~ModelManagerTestHelper()
{ {
cleanup(); cleanup();
QVERIFY(Tests::VerifyCleanCppModelManager::isClean()); QVERIFY(Tests::VerifyCleanCppModelManager::isClean(m_testOnlyForCleanedProjects));
} }
void ModelManagerTestHelper::cleanup() void ModelManagerTestHelper::cleanup()

4
src/plugins/cpptools/modelmanagertesthelper.h
View File

@@ -75,7 +75,8 @@ class CPPTOOLS_EXPORT ModelManagerTestHelper: public QObject
public: public:
typedef ProjectExplorer::Project Project; typedef ProjectExplorer::Project Project;
explicit ModelManagerTestHelper(QObject *parent = 0); explicit ModelManagerTestHelper(QObject *parent = 0,
bool testOnlyForCleanedProjects = true);
~ModelManagerTestHelper(); ~ModelManagerTestHelper();
void cleanup(); void cleanup();
@@ -99,6 +100,7 @@ public slots:
private: private:
bool m_gcFinished; bool m_gcFinished;
bool m_refreshHappened; bool m_refreshHappened;
bool m_testOnlyForCleanedProjects;
QSet<QString> m_lastRefreshedSourceFiles; QSet<QString> m_lastRefreshedSourceFiles;
}; };