feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Log errors to issues pane instead of popping up a QMessageBox.

Browse Source 
Just as informative, but less intrusive and can't introduce event loop
problems.

Change-Id: I7dec17b1e82ba23340376075125f965017047959
Reviewed-by: hjk <hjk@theqtcompany.com>
This commit is contained in:
Christian Kandeler
2015-03-03 12:13:21 +01:00
parent b70081ae71
commit c5dfc33b3d
4 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/valgrind/callgrindtool.cpp
View File

@@ -88,7 +88,6 @@
#include <QHBoxLayout>
#include <QLineEdit>
#include <QMenu>
#include <QMessageBox>
#include <QSortFilterProxyModel>
#include <QToolBar>
#include <QToolButton>
@@ -933,8 +932,8 @@ void CallgrindToolPrivate::loadExternalLogFile()
QFile logFile(filePath);
if (!logFile.open(QIODevice::ReadOnly | QIODevice::Text)) {
QMessageBox::critical(AnalyzerManager::mainWindow(), tr("Internal Error"),
tr("Failed to open file for reading: %1").arg(filePath));
AnalyzerUtils::logToIssuesPane(Task::Error,
tr("Callgrind: Failed to open file for reading: %1").arg(filePath));
return;
}