feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Log errors to issues pane instead of popping up a QMessageBox.

Browse Source 
Just as informative, but less intrusive and can't introduce event loop
problems.

Change-Id: I7dec17b1e82ba23340376075125f965017047959
Reviewed-by: hjk <hjk@theqtcompany.com>
This commit is contained in:
Christian Kandeler
2015-03-03 12:13:21 +01:00
parent b70081ae71
commit c5dfc33b3d
4 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/valgrind/memchecktool.cpp
View File

@@ -36,6 +36,7 @@
#include "valgrindplugin.h"
#include <analyzerbase/analyzermanager.h>
#include <analyzerbase/analyzerutils.h>
#include <analyzerbase/analyzerconstants.h>
#include <valgrind/valgrindsettings.h>
@@ -83,7 +84,6 @@
#include <QSpinBox>
#include <QAction>
#include <QMenu>
#include <QMessageBox>
#include <QToolButton>
#include <QCheckBox>
#include <utils/stylehelper.h>
@@ -493,8 +493,8 @@ void MemcheckTool::loadExternalXmlLogFile()
QFile *logFile = new QFile(filePath);
if (!logFile->open(QIODevice::ReadOnly | QIODevice::Text)) {
delete logFile;
QMessageBox::critical(m_errorView, tr("Internal Error"),
tr("Failed to open file for reading: %1").arg(filePath));
AnalyzerUtils::logToIssuesPane(Task::Error,
tr("Memcheck: Failed to open file for reading: %1").arg(filePath));
return;
}
@@ -524,8 +524,8 @@ void MemcheckTool::parserError(const Error &error)
void MemcheckTool::internalParserError(const QString &errorString)
{
QMessageBox::critical(m_errorView, tr("Internal Error"),
tr("Error occurred parsing Valgrind output: %1").arg(errorString));
AnalyzerUtils::logToIssuesPane(Task::Error,
tr("Memcheck: Error occurred parsing Valgrind output: %1").arg(errorString));
}
void MemcheckTool::clearErrorView()