feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppTools: Fix some clazy level0 warnings

Browse Source 
Use midRef() instead [-Wclazy-qstring-ref]
Use multi-arg instead [-Wclazy-qstring-arg]

Change-Id: I74d79c4d9595aabd6b2b621743055b807652383c
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Nikolai Kosjar
2019-02-07 12:36:07 +01:00
parent 12f4b1ee86
commit c62f811c4b
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cpptools/cppcodemodelsettings.cpp
View File

@@ -90,7 +90,7 @@ static QString convertToNewClazyChecksFormat(const QString &checks)
if (checks.size() == 6 && checks.startsWith("level")) { if (checks.size() == 6 && checks.startsWith("level")) {
bool ok = false; bool ok = false;
const int level = checks.mid(5).toInt(&ok); const int level = checks.midRef(5).toInt(&ok);
QTC_ASSERT(ok, return QString()); QTC_ASSERT(ok, return QString());
return clazyChecksForLevel(level); return clazyChecksForLevel(level);
} }

2
src/plugins/cpptools/cppprojectfilecategorizer.cpp
View File

@@ -47,7 +47,7 @@ ProjectFileCategorizer::ProjectFileCategorizer(const QString &projectPartName,
QString ProjectFileCategorizer::partName(const QString &languageName) const QString ProjectFileCategorizer::partName(const QString &languageName) const
{ {
if (hasMultipleParts()) if (hasMultipleParts())
return QString::fromLatin1("%1 (%2)").arg(m_partName).arg(languageName); return QString::fromLatin1("%1 (%2)").arg(m_partName, languageName);
return m_partName; return m_partName;
} }

6
src/plugins/cpptools/symbolsfindfilter.cpp
View File

@@ -248,9 +248,9 @@ QString SymbolsFindFilter::toolTip(FindFlags findFlags) const
if (m_symbolsToSearch & SymbolSearcher::Declarations) if (m_symbolsToSearch & SymbolSearcher::Declarations)
types.append(tr("Declarations")); types.append(tr("Declarations"));
return tr("Scope: %1\nTypes: %2\nFlags: %3") return tr("Scope: %1\nTypes: %2\nFlags: %3")
.arg(searchScope() == SymbolSearcher::SearchGlobal ? tr("All") : tr("Projects")) .arg(searchScope() == SymbolSearcher::SearchGlobal ? tr("All") : tr("Projects"),
.arg(types.join(tr(", "))) types.join(", "),
.arg(IFindFilter::descriptionForFindFlags(findFlags)); IFindFilter::descriptionForFindFlags(findFlags));
} }
// #pragma mark -- SymbolsFindFilterConfigWidget // #pragma mark -- SymbolsFindFilterConfigWidget