feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppEditor: Remove some virtual functions from ModelManagerSupport

Browse Source 
These were never called via the base pointer.

Change-Id: Ib233d9e93d80b1fbcc09a5b7b07d9fa3b8615f66
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Christian Kandeler
2022-08-02 16:40:34 +02:00
parent c0b3cc1bbc
commit c6399adf48
4 changed files with 4 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/clangcodemodel/clangmodelmanagersupport.cpp
View File

@@ -217,11 +217,6 @@ ClangModelManagerSupport::~ClangModelManagerSupport()
m_instance = nullptr;
}
CppEditor::CppCompletionAssistProvider *ClangModelManagerSupport::completionAssistProvider()
{
return nullptr;
}
void ClangModelManagerSupport::followSymbol(const CppEditor::CursorInEditor &data,
const Utils::LinkHandler &processLinkCallback, bool resolveTarget,
bool inNextSplit)
@@ -306,11 +301,6 @@ void ClangModelManagerSupport::switchHeaderSource(const Utils::FilePath &filePat
CppModelManager::switchHeaderSource(inNextSplit, CppModelManager::Backend::Builtin);
}
std::unique_ptr<CppEditor::AbstractOverviewModel> ClangModelManagerSupport::createOverviewModel()
{
return {};
}
bool ClangModelManagerSupport::usesClangd(const TextEditor::TextDocument *document) const
{
return clientForFile(document->filePath());

3
src/plugins/clangcodemodel/clangmodelmanagersupport.h
View File

@@ -62,11 +62,8 @@ public:
ClangModelManagerSupport();
~ClangModelManagerSupport() override;
CppEditor::CppCompletionAssistProvider *completionAssistProvider() override;
TextEditor::BaseHoverHandler *createHoverHandler() override { return nullptr; }
CppEditor::BaseEditorDocumentProcessor *createEditorDocumentProcessor(
TextEditor::TextDocument *baseTextDocument) override;
std::unique_ptr<CppEditor::AbstractOverviewModel> createOverviewModel() override;
bool usesClangd(const TextEditor::TextDocument *document) const override;
static ClangdClient *clientForProject(const ProjectExplorer::Project *project);