CppEditor: Remove some virtual functions from ModelManagerSupport

These were never called via the base pointer.

Change-Id: Ib233d9e93d80b1fbcc09a5b7b07d9fa3b8615f66
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Christian Stenger <christian.stenger@qt.io>

src/plugins/clangcodemodel/clangmodelmanagersupport.cpp

@@ -217,11 +217,6 @@ ClangModelManagerSupport::~ClangModelManagerSupport()
     m_instance = nullptr;
 }
 
-CppEditor::CppCompletionAssistProvider *ClangModelManagerSupport::completionAssistProvider()
-{
-    return nullptr;
-}
-
 void ClangModelManagerSupport::followSymbol(const CppEditor::CursorInEditor &data,
                   const Utils::LinkHandler &processLinkCallback, bool resolveTarget,
                   bool inNextSplit)
@@ -306,11 +301,6 @@ void ClangModelManagerSupport::switchHeaderSource(const Utils::FilePath &filePat
     CppModelManager::switchHeaderSource(inNextSplit, CppModelManager::Backend::Builtin);
 }
 
-std::unique_ptr<CppEditor::AbstractOverviewModel> ClangModelManagerSupport::createOverviewModel()
-{
-    return {};
-}
-
 bool ClangModelManagerSupport::usesClangd(const TextEditor::TextDocument *document) const
 {
     return clientForFile(document->filePath());

src/plugins/clangcodemodel/clangmodelmanagersupport.h

@@ -62,11 +62,8 @@ public:
     ClangModelManagerSupport();
     ~ClangModelManagerSupport() override;
 
-    CppEditor::CppCompletionAssistProvider *completionAssistProvider() override;
-    TextEditor::BaseHoverHandler *createHoverHandler() override { return nullptr; }
     CppEditor::BaseEditorDocumentProcessor *createEditorDocumentProcessor(
                 TextEditor::TextDocument *baseTextDocument) override;
-    std::unique_ptr<CppEditor::AbstractOverviewModel> createOverviewModel() override;
     bool usesClangd(const TextEditor::TextDocument *document) const override;
 
     static ClangdClient *clientForProject(const ProjectExplorer::Project *project);

src/plugins/cppeditor/cppbuiltinmodelmanagersupport.h

@@ -41,11 +41,12 @@ public:
     BuiltinModelManagerSupport();
     ~BuiltinModelManagerSupport() override;
 
-    CppCompletionAssistProvider *completionAssistProvider() final;
+    CppCompletionAssistProvider *completionAssistProvider();
-    TextEditor::BaseHoverHandler *createHoverHandler() final;
+    TextEditor::BaseHoverHandler *createHoverHandler();
+    std::unique_ptr<AbstractOverviewModel> createOverviewModel();
+
     BaseEditorDocumentProcessor *createEditorDocumentProcessor(
             TextEditor::TextDocument *baseTextDocument) final;
-    std::unique_ptr<AbstractOverviewModel> createOverviewModel() final;
 
     FollowSymbolUnderCursor &followSymbolInterface() { return *m_followSymbol; }
 

src/plugins/cppeditor/cppmodelmanagersupport.h

@@ -56,11 +56,8 @@ public:
 public:
     virtual ~ModelManagerSupport() = 0;
 
-    virtual CppCompletionAssistProvider *completionAssistProvider() = 0;
-    virtual TextEditor::BaseHoverHandler *createHoverHandler() = 0;
     virtual BaseEditorDocumentProcessor *createEditorDocumentProcessor(
                 TextEditor::TextDocument *baseTextDocument) = 0;
-    virtual std::unique_ptr<AbstractOverviewModel> createOverviewModel() = 0;
     virtual bool usesClangd(const TextEditor::TextDocument *) const { return false; }
 
     virtual void followSymbol(const CursorInEditor &data,