From c655c1733b72fffe78a277d5df582ccf91096e3e Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Fri, 1 Sep 2023 17:20:47 +0200
Subject: [PATCH] Clean up some navigation factory implementation

Change-Id: Ibbff643daf88200d50fb0343dd40b03803074081
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
---
 .../classview/classviewnavigationwidgetfactory.h    | 13 ++-----------
 src/plugins/coreplugin/inavigationwidgetfactory.h   |  1 -
 src/plugins/languageclient/callhierarchy.h          |  6 ++----
 3 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/src/plugins/classview/classviewnavigationwidgetfactory.h b/src/plugins/classview/classviewnavigationwidgetfactory.h
index 2eed11b4fe0..0ec38a4eeeb 100644
--- a/src/plugins/classview/classviewnavigationwidgetfactory.h
+++ b/src/plugins/classview/classviewnavigationwidgetfactory.h
@@ -5,25 +5,16 @@
 
 #include <coreplugin/inavigationwidgetfactory.h>
 
-namespace ClassView {
-namespace Internal {
+namespace ClassView::Internal {
 
 class NavigationWidgetFactory : public Core::INavigationWidgetFactory
 {
-    Q_OBJECT
-
 public:
     NavigationWidgetFactory();
 
-    //! \implements Core::INavigationWidgetFactory::createWidget
     Core::NavigationView createWidget() override;
-
-    //! \implements Core::INavigationWidgetFactory::saveSettings
     void saveSettings(Utils::QtcSettings *settings, int position, QWidget *widget) override;
-
-    //! \implements Core::INavigationWidgetFactory::restoreSettings
     void restoreSettings(Utils::QtcSettings *settings, int position, QWidget *widget) override;
 };
 
-} // namespace Internal
-} // namespace ClassView
+} // ClassView::Internal
diff --git a/src/plugins/coreplugin/inavigationwidgetfactory.h b/src/plugins/coreplugin/inavigationwidgetfactory.h
index 84b8b180171..6be77939fbd 100644
--- a/src/plugins/coreplugin/inavigationwidgetfactory.h
+++ b/src/plugins/coreplugin/inavigationwidgetfactory.h
@@ -13,7 +13,6 @@
 #include <QKeySequence>
 
 QT_BEGIN_NAMESPACE
-class QSettings;
 class QToolButton;
 class QWidget;
 QT_END_NAMESPACE
diff --git a/src/plugins/languageclient/callhierarchy.h b/src/plugins/languageclient/callhierarchy.h
index bbc15b09712..79c92fd3600 100644
--- a/src/plugins/languageclient/callhierarchy.h
+++ b/src/plugins/languageclient/callhierarchy.h
@@ -1,10 +1,10 @@
 // Copyright (C) 2022 The Qt Company Ltd.
 // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0 WITH Qt-GPL-exception-1.0
 
-#include <coreplugin/inavigationwidgetfactory.h>
-
 #pragma once
 
+#include <coreplugin/inavigationwidgetfactory.h>
+
 namespace Core { class IDocument; }
 
 namespace LanguageClient {
@@ -13,8 +13,6 @@ class Client;
 
 class CallHierarchyFactory : public Core::INavigationWidgetFactory
 {
-    Q_OBJECT
-
 public:
     CallHierarchyFactory();