From c66b2cdef796728d028c8849b70c24b65c1d286f Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Fri, 19 Oct 2018 14:45:50 +0200 Subject: [PATCH] Debugger: Fix removing breakpoints for pdb ...if the break point has not yet got a response id we end up in an interactive prompt of pdb asking for the breakpoint to remove. Avoid this as this leads to other follow-up problems. Change-Id: Ifa2b5385b61af6bf05b816c8e82d2b515525805b Reviewed-by: hjk --- src/plugins/debugger/pdb/pdbengine.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/plugins/debugger/pdb/pdbengine.cpp b/src/plugins/debugger/pdb/pdbengine.cpp index c465be65a1f..8274b5d68fa 100644 --- a/src/plugins/debugger/pdb/pdbengine.cpp +++ b/src/plugins/debugger/pdb/pdbengine.cpp @@ -264,6 +264,10 @@ void PdbEngine::removeBreakpoint(const Breakpoint &bp) QTC_ASSERT(bp, return); QTC_CHECK(bp->state() == BreakpointRemoveRequested); notifyBreakpointRemoveProceeding(bp); + if (bp->responseId().isEmpty()) { + notifyBreakpointRemoveFailed(bp); + return; + } showMessage(QString("DELETING BP %1 IN %2") .arg(bp->responseId()).arg(bp->fileName())); postDirectCommand("clear " + bp->responseId());