diff --git a/src/plugins/coreplugin/coreplugin.cpp b/src/plugins/coreplugin/coreplugin.cpp index 83f21201678..043bdba74d1 100644 --- a/src/plugins/coreplugin/coreplugin.cpp +++ b/src/plugins/coreplugin/coreplugin.cpp @@ -313,12 +313,6 @@ QObject *CorePlugin::remoteCommand(const QStringList & /* options */, return res; } -FutureSynchronizer *CorePlugin::futureSynchronizer() -{ - QTC_ASSERT(m_instance, return nullptr); - return &m_instance->m_futureSynchronizer; -} - Environment CorePlugin::startupSystemEnvironment() { return m_instance->m_startupSystemEnvironment; diff --git a/src/plugins/coreplugin/coreplugin.h b/src/plugins/coreplugin/coreplugin.h index b415ba146e3..3f535be8a65 100644 --- a/src/plugins/coreplugin/coreplugin.h +++ b/src/plugins/coreplugin/coreplugin.h @@ -8,7 +8,6 @@ #include #include -#include QT_BEGIN_NAMESPACE class QMenu; @@ -47,7 +46,6 @@ public: const QString &workingDirectory, const QStringList &args) override; - static Utils::FutureSynchronizer *futureSynchronizer(); static Utils::Environment startupSystemEnvironment(); static Utils::EnvironmentItems environmentChanges(); static void setEnvironmentChanges(const Utils::EnvironmentItems &changes); @@ -79,7 +77,6 @@ private: FolderNavigationWidgetFactory *m_folderNavigationWidgetFactory = nullptr; Utils::Environment m_startupSystemEnvironment; Utils::EnvironmentItems m_environmentChanges; - Utils::FutureSynchronizer m_futureSynchronizer; }; } // namespace Internal diff --git a/src/plugins/coreplugin/locator/filesystemfilter.cpp b/src/plugins/coreplugin/locator/filesystemfilter.cpp index 75bbcba1511..8facb0304a8 100644 --- a/src/plugins/coreplugin/locator/filesystemfilter.cpp +++ b/src/plugins/coreplugin/locator/filesystemfilter.cpp @@ -3,13 +3,14 @@ #include "filesystemfilter.h" -#include "../coreplugin.h" #include "../coreplugintr.h" #include "../documentmanager.h" #include "../editormanager/editormanager.h" #include "../icore.h" #include "../vcsmanager.h" +#include + #include #include #include @@ -273,7 +274,7 @@ LocatorMatcherTasks FileSystemFilter::matchers() TreeStorage storage; const auto onSetup = [this, storage](AsyncTask &async) { - async.setFutureSynchronizer(CorePlugin::futureSynchronizer()); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); async.setConcurrentCallData(matches, *storage, shortcutString(), diff --git a/src/plugins/coreplugin/locator/ilocatorfilter.cpp b/src/plugins/coreplugin/locator/ilocatorfilter.cpp index 58b4024639d..7a6e761b2a5 100644 --- a/src/plugins/coreplugin/locator/ilocatorfilter.cpp +++ b/src/plugins/coreplugin/locator/ilocatorfilter.cpp @@ -3,9 +3,10 @@ #include "ilocatorfilter.h" -#include "../coreplugin.h" #include "../coreplugintr.h" +#include + #include #include #include @@ -273,7 +274,7 @@ ResultsCollector::~ResultsCollector() return; m_deduplicator->cancel(); - Internal::CorePlugin::futureSynchronizer()->addFuture(m_watcher->future()); + ExtensionSystem::PluginManager::futureSynchronizer()->addFuture(m_watcher->future()); } void ResultsCollector::setFilterCount(int count) diff --git a/src/plugins/coreplugin/locator/opendocumentsfilter.cpp b/src/plugins/coreplugin/locator/opendocumentsfilter.cpp index 4a510ad83f7..9cfccb8ca67 100644 --- a/src/plugins/coreplugin/locator/opendocumentsfilter.cpp +++ b/src/plugins/coreplugin/locator/opendocumentsfilter.cpp @@ -3,9 +3,10 @@ #include "opendocumentsfilter.h" -#include "../coreplugin.h" #include "../coreplugintr.h" +#include + #include #include #include @@ -81,7 +82,7 @@ LocatorMatcherTasks OpenDocumentsFilter::matchers() const auto onSetup = [storage](AsyncTask &async) { const QList editorsData = Utils::transform(DocumentModel::entries(), [](const DocumentModel::Entry *e) { return Entry{e->filePath(), e->displayName()}; }); - async.setFutureSynchronizer(CorePlugin::futureSynchronizer()); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); async.setConcurrentCallData(matchEditors, *storage, editorsData); }; diff --git a/src/plugins/cppeditor/cppeditorplugin.cpp b/src/plugins/cppeditor/cppeditorplugin.cpp index 53d6ef55bda..2d4cabe726e 100644 --- a/src/plugins/cppeditor/cppeditorplugin.cpp +++ b/src/plugins/cppeditor/cppeditorplugin.cpp @@ -85,7 +85,6 @@ #include #include #include -#include #include #include #include @@ -199,7 +198,6 @@ public: ClangdSettingsPage *m_clangdSettingsPage = nullptr; CppCodeStyleSettingsPage m_cppCodeStyleSettingsPage; CppProjectUpdaterFactory m_cppProjectUpdaterFactory; - FutureSynchronizer m_futureSynchronizer; }; static CppEditorPlugin *m_instance = nullptr; @@ -633,12 +631,6 @@ bool CppEditorPlugin::usePragmaOnce() return m_instance->d->m_fileSettings.headerPragmaOnce; } -FutureSynchronizer *CppEditorPlugin::futureSynchronizer() -{ - QTC_ASSERT(m_instance, return nullptr); - return &m_instance->d->m_futureSynchronizer; -} - const QStringList &CppEditorPlugin::headerSearchPaths() { return m_instance->d->m_fileSettings.headerSearchPaths; diff --git a/src/plugins/cppeditor/cppeditorplugin.h b/src/plugins/cppeditor/cppeditorplugin.h index b24bc927f65..c28ee16b1e1 100644 --- a/src/plugins/cppeditor/cppeditorplugin.h +++ b/src/plugins/cppeditor/cppeditorplugin.h @@ -5,10 +5,7 @@ #include -namespace Utils { -class FilePath; -class FutureSynchronizer; -} +namespace Utils { class FilePath; } namespace CppEditor { class CppCodeModelSettings; @@ -40,7 +37,6 @@ public: static Utils::FilePath licenseTemplatePath(); static QString licenseTemplate(); static bool usePragmaOnce(); - static Utils::FutureSynchronizer *futureSynchronizer(); void openDeclarationDefinitionInNextSplit(); void openTypeHierarchy(); diff --git a/src/plugins/cppeditor/cpplocatorfilter.cpp b/src/plugins/cppeditor/cpplocatorfilter.cpp index 6ec6602f62e..c13948bb3e9 100644 --- a/src/plugins/cppeditor/cpplocatorfilter.cpp +++ b/src/plugins/cppeditor/cpplocatorfilter.cpp @@ -12,6 +12,8 @@ #include #include +#include + #include #include #include @@ -107,7 +109,7 @@ LocatorMatcherTask locatorMatcher(IndexItem::ItemType type, const EntryFromIndex TreeStorage storage; const auto onSetup = [=](AsyncTask &async) { - async.setFutureSynchronizer(Internal::CppEditorPlugin::futureSynchronizer()); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); async.setConcurrentCallData(matchesFor, *storage, type, converter); }; return {Async(onSetup), storage}; @@ -303,7 +305,7 @@ LocatorMatcherTask currentDocumentMatcher() TreeStorage storage; const auto onSetup = [=](AsyncTask &async) { - async.setFutureSynchronizer(Internal::CppEditorPlugin::futureSynchronizer()); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); async.setConcurrentCallData(matchesForCurrentDocument, *storage, currentFileName()); }; return {Async(onSetup), storage}; diff --git a/src/plugins/diffeditor/diffeditorplugin.cpp b/src/plugins/diffeditor/diffeditorplugin.cpp index 6ae5f816c30..eed5a6d0e4a 100644 --- a/src/plugins/diffeditor/diffeditorplugin.cpp +++ b/src/plugins/diffeditor/diffeditorplugin.cpp @@ -13,12 +13,13 @@ #include #include +#include + #include #include #include #include -#include #include #include @@ -114,8 +115,9 @@ DiffFilesController::DiffFilesController(IDocument *document) QList> *outputList = storage.activeStorage(); const auto setupDiff = [this](AsyncTask &async, const ReloadInput &reloadInput) { - async.setConcurrentCallData(DiffFile(ignoreWhitespace(), contextLineCount()), reloadInput); - async.setFutureSynchronizer(Internal::DiffEditorPlugin::futureSynchronizer()); + async.setConcurrentCallData( + DiffFile(ignoreWhitespace(), contextLineCount()), reloadInput); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); }; const auto onDiffDone = [outputList](const AsyncTask &async, int i) { if (async.isResultAvailable()) @@ -415,12 +417,10 @@ public: DiffEditorFactory m_editorFactory; DiffEditorServiceImpl m_service; - FutureSynchronizer m_futureSynchronizer; }; DiffEditorPluginPrivate::DiffEditorPluginPrivate() { - m_futureSynchronizer.setCancelOnWait(true); //register actions ActionContainer *toolsContainer = ActionManager::actionContainer(Core::Constants::M_TOOLS); toolsContainer->insertGroup(Core::Constants::G_TOOLS_DEBUG, Constants::G_TOOLS_DIFF); @@ -535,12 +535,6 @@ void DiffEditorPlugin::initialize() d = new DiffEditorPluginPrivate; } -FutureSynchronizer *DiffEditorPlugin::futureSynchronizer() -{ - QTC_ASSERT(s_instance, return nullptr); - return &s_instance->d->m_futureSynchronizer; -} - } // namespace Internal } // namespace DiffEditor diff --git a/src/plugins/diffeditor/diffeditorplugin.h b/src/plugins/diffeditor/diffeditorplugin.h index 66849a7387e..17b6a2d430d 100644 --- a/src/plugins/diffeditor/diffeditorplugin.h +++ b/src/plugins/diffeditor/diffeditorplugin.h @@ -6,8 +6,6 @@ #include #include -namespace Utils { class FutureSynchronizer; } - namespace DiffEditor { namespace Internal { @@ -34,8 +32,6 @@ public: void initialize() final; - static Utils::FutureSynchronizer *futureSynchronizer(); - private: class DiffEditorPluginPrivate *d = nullptr; diff --git a/src/plugins/diffeditor/sidebysidediffeditorwidget.cpp b/src/plugins/diffeditor/sidebysidediffeditorwidget.cpp index 6847bf0e3a2..f1467f6ea27 100644 --- a/src/plugins/diffeditor/sidebysidediffeditorwidget.cpp +++ b/src/plugins/diffeditor/sidebysidediffeditorwidget.cpp @@ -5,7 +5,6 @@ #include "diffeditorconstants.h" #include "diffeditordocument.h" -#include "diffeditorplugin.h" #include "diffeditortr.h" #include @@ -13,6 +12,8 @@ #include #include +#include + #include #include #include @@ -869,7 +870,7 @@ void SideBySideDiffEditorWidget::restoreState() void SideBySideDiffEditorWidget::showDiff() { m_asyncTask.reset(new AsyncTask()); - m_asyncTask->setFutureSynchronizer(DiffEditorPlugin::futureSynchronizer()); + m_asyncTask->setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); m_controller.setBusyShowing(true); connect(m_asyncTask.get(), &AsyncTaskBase::done, this, [this] { diff --git a/src/plugins/diffeditor/unifieddiffeditorwidget.cpp b/src/plugins/diffeditor/unifieddiffeditorwidget.cpp index cb113612c20..d914ef59cb5 100644 --- a/src/plugins/diffeditor/unifieddiffeditorwidget.cpp +++ b/src/plugins/diffeditor/unifieddiffeditorwidget.cpp @@ -5,12 +5,13 @@ #include "diffeditorconstants.h" #include "diffeditordocument.h" -#include "diffeditorplugin.h" #include "diffeditortr.h" #include #include +#include + #include #include #include @@ -452,7 +453,7 @@ void UnifiedDiffEditorWidget::showDiff() } m_asyncTask.reset(new AsyncTask()); - m_asyncTask->setFutureSynchronizer(DiffEditorPlugin::futureSynchronizer()); + m_asyncTask->setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); m_controller.setBusyShowing(true); connect(m_asyncTask.get(), &AsyncTaskBase::done, this, [this] { if (m_asyncTask->isCanceled() || !m_asyncTask->isResultAvailable()) { diff --git a/src/plugins/help/helpindexfilter.cpp b/src/plugins/help/helpindexfilter.cpp index 2d005079973..4c4b5be0251 100644 --- a/src/plugins/help/helpindexfilter.cpp +++ b/src/plugins/help/helpindexfilter.cpp @@ -97,7 +97,7 @@ LocatorMatcherTasks HelpIndexFilter::matchers() } const QStringList cache = m_lastEntry.isEmpty() || !storage->input().contains(m_lastEntry) ? m_allIndicesCache : m_lastIndicesCache; - async.setFutureSynchronizer(HelpPlugin::futureSynchronizer()); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); async.setConcurrentCallData(matches, *storage, cache, m_icon); }; const auto onDone = [this, storage](const AsyncTask &async) { diff --git a/src/plugins/help/helpplugin.cpp b/src/plugins/help/helpplugin.cpp index 045035d093f..e46effd10b7 100644 --- a/src/plugins/help/helpplugin.cpp +++ b/src/plugins/help/helpplugin.cpp @@ -43,7 +43,6 @@ #include #include -#include #include #include #include @@ -143,7 +142,6 @@ public: LocalHelpManager m_localHelpManager; HelpIndexFilter helpIndexFilter; - FutureSynchronizer m_futureSynchronizer; }; static HelpPluginPrivate *dd = nullptr; @@ -397,12 +395,6 @@ HelpWidget *HelpPlugin::modeHelpWidget() return dd->m_centralWidget; } -FutureSynchronizer *HelpPlugin::futureSynchronizer() -{ - QTC_ASSERT(dd, return nullptr); - return &dd->m_futureSynchronizer; -} - void HelpPluginPrivate::showLinksInCurrentViewer(const QMultiMap &links, const QString &key) { if (links.size() < 1) diff --git a/src/plugins/help/helpplugin.h b/src/plugins/help/helpplugin.h index bd483ae3da8..96d14a152b8 100644 --- a/src/plugins/help/helpplugin.h +++ b/src/plugins/help/helpplugin.h @@ -10,8 +10,6 @@ QT_BEGIN_NAMESPACE class QUrl; QT_END_NAMESPACE -namespace Utils { class FutureSynchronizer; } - namespace Help { namespace Internal { @@ -32,7 +30,6 @@ public: const QString &key); static HelpViewer *createHelpViewer(); static HelpWidget *modeHelpWidget(); - static Utils::FutureSynchronizer *futureSynchronizer(); private: void initialize() final; diff --git a/src/plugins/languageclient/languageclientplugin.cpp b/src/plugins/languageclient/languageclientplugin.cpp index b1001137662..7332f03e2b1 100644 --- a/src/plugins/languageclient/languageclientplugin.cpp +++ b/src/plugins/languageclient/languageclientplugin.cpp @@ -33,12 +33,6 @@ LanguageClientPlugin *LanguageClientPlugin::instance() return m_instance; } -Utils::FutureSynchronizer *LanguageClientPlugin::futureSynchronizer() -{ - QTC_ASSERT(m_instance, return nullptr); - return &m_instance->m_futureSynchronizer; -} - void LanguageClientPlugin::initialize() { using namespace Core; diff --git a/src/plugins/languageclient/languageclientplugin.h b/src/plugins/languageclient/languageclientplugin.h index 52e8dde9072..b8eb3ac00a2 100644 --- a/src/plugins/languageclient/languageclientplugin.h +++ b/src/plugins/languageclient/languageclientplugin.h @@ -8,8 +8,6 @@ #include -#include - namespace LanguageClient { class LanguageClientPlugin : public ExtensionSystem::IPlugin @@ -21,7 +19,6 @@ public: ~LanguageClientPlugin() override; static LanguageClientPlugin *instance(); - static Utils::FutureSynchronizer *futureSynchronizer(); // IPlugin interface private: @@ -32,7 +29,6 @@ private: private: LanguageClientOutlineWidgetFactory m_outlineFactory; CallHierarchyFactory m_callHierarchyFactory; - Utils::FutureSynchronizer m_futureSynchronizer; #ifdef WITH_TESTS private slots: diff --git a/src/plugins/languageclient/locatorfilter.cpp b/src/plugins/languageclient/locatorfilter.cpp index 2e61204a62f..16c0d52c72d 100644 --- a/src/plugins/languageclient/locatorfilter.cpp +++ b/src/plugins/languageclient/locatorfilter.cpp @@ -8,11 +8,12 @@ #include "documentsymbolcache.h" #include "languageclient_global.h" #include "languageclientmanager.h" -#include "languageclientplugin.h" #include "languageclienttr.h" #include +#include + #include #include @@ -78,7 +79,7 @@ LocatorMatcherTask locatorMatcher(Client *client, int maxResultCount, const QList results = *resultStorage; if (results.isEmpty()) return TaskAction::StopWithDone; - async.setFutureSynchronizer(LanguageClientPlugin::futureSynchronizer()); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); async.setConcurrentCallData(filterResults, *storage, client, results, filter); return TaskAction::Continue; }; @@ -138,7 +139,7 @@ LocatorMatcherTask currentDocumentMatcher() }; const auto onFilterSetup = [=](AsyncTask &async) { - async.setFutureSynchronizer(LanguageClientPlugin::futureSynchronizer()); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); async.setConcurrentCallData(filterCurrentResults, *storage, *resultStorage); }; diff --git a/src/plugins/projectexplorer/extracompiler.cpp b/src/plugins/projectexplorer/extracompiler.cpp index ccf2971774c..7fe408a362e 100644 --- a/src/plugins/projectexplorer/extracompiler.cpp +++ b/src/plugins/projectexplorer/extracompiler.cpp @@ -11,6 +11,8 @@ #include #include +#include + #include #include #include @@ -45,7 +47,6 @@ public: QTimer timer; - FutureSynchronizer m_futureSynchronizer; std::unique_ptr m_taskTree; }; @@ -291,11 +292,6 @@ Environment ExtraCompiler::buildEnvironment() const return env; } -FutureSynchronizer *ExtraCompiler::futureSynchronizer() const -{ - return &d->m_futureSynchronizer; -} - void ExtraCompiler::setContent(const FilePath &file, const QByteArray &contents) { qCDebug(log).noquote() << Q_FUNC_INFO << contents; @@ -333,9 +329,9 @@ Tasking::TaskItem ProcessExtraCompiler::taskItemImpl(const ContentProvider &prov { const auto setupTask = [=](AsyncTask &async) { async.setThreadPool(extraCompilerThreadPool()); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); async.setConcurrentCallData(&ProcessExtraCompiler::runInThread, this, command(), workingDirectory(), arguments(), provider, buildEnvironment()); - async.setFutureSynchronizer(futureSynchronizer()); }; const auto taskDone = [=](const AsyncTask &async) { if (!async.isResultAvailable()) diff --git a/src/plugins/projectexplorer/extracompiler.h b/src/plugins/projectexplorer/extracompiler.h index 4f0e6da47b3..889a79f858e 100644 --- a/src/plugins/projectexplorer/extracompiler.h +++ b/src/plugins/projectexplorer/extracompiler.h @@ -25,10 +25,7 @@ class QPromise; class QThreadPool; QT_END_NAMESPACE -namespace Utils { -class FutureSynchronizer; -class QtcProcess; -} +namespace Utils { class QtcProcess; } namespace ProjectExplorer { @@ -64,7 +61,6 @@ signals: protected: static QThreadPool *extraCompilerThreadPool(); - Utils::FutureSynchronizer *futureSynchronizer() const; void setContent(const Utils::FilePath &file, const QByteArray &content); void updateCompileTime(); Utils::Environment buildEnvironment() const; diff --git a/src/plugins/python/pythonplugin.cpp b/src/plugins/python/pythonplugin.cpp index 1fd12def06e..67857aec236 100644 --- a/src/plugins/python/pythonplugin.cpp +++ b/src/plugins/python/pythonplugin.cpp @@ -18,7 +18,6 @@ #include #include -#include #include using namespace ProjectExplorer; @@ -38,7 +37,6 @@ public: PySideBuildConfigurationFactory buildConfigFactory; SimpleTargetRunnerFactory runWorkerFactory{{runConfigFactory.runConfigurationId()}}; PythonSettings settings; - FutureSynchronizer m_futureSynchronizer; }; PythonPlugin::PythonPlugin() @@ -57,12 +55,6 @@ PythonPlugin *PythonPlugin::instance() return m_instance; } -FutureSynchronizer *PythonPlugin::futureSynchronizer() -{ - QTC_ASSERT(m_instance, return nullptr); - return &m_instance->d->m_futureSynchronizer; -} - void PythonPlugin::initialize() { d = new PythonPluginPrivate; diff --git a/src/plugins/python/pythonplugin.h b/src/plugins/python/pythonplugin.h index 7c8ca121f3c..ef0860bbca4 100644 --- a/src/plugins/python/pythonplugin.h +++ b/src/plugins/python/pythonplugin.h @@ -5,8 +5,6 @@ #include -namespace Utils { class FutureSynchronizer; } - namespace Python::Internal { class PythonPlugin final : public ExtensionSystem::IPlugin @@ -19,7 +17,6 @@ public: ~PythonPlugin() final; static PythonPlugin *instance(); - static Utils::FutureSynchronizer *futureSynchronizer(); private: void initialize() final; diff --git a/src/plugins/python/pythonrunconfiguration.cpp b/src/plugins/python/pythonrunconfiguration.cpp index 552d41128b3..537da98125f 100644 --- a/src/plugins/python/pythonrunconfiguration.cpp +++ b/src/plugins/python/pythonrunconfiguration.cpp @@ -9,7 +9,6 @@ #include "pysideuicextracompiler.h" #include "pythonconstants.h" #include "pythonlanguageclient.h" -#include "pythonplugin.h" #include "pythonproject.h" #include "pythonsettings.h" #include "pythontr.h" @@ -17,6 +16,8 @@ #include #include +#include + #include #include @@ -248,7 +249,7 @@ void PythonRunConfigurationPrivate::checkForPySide(const FilePath &python, }); const auto future = Pip::instance(python)->info(package); m_watcher.setFuture(future); - PythonPlugin::futureSynchronizer()->addFuture(future); + ExtensionSystem::PluginManager::futureSynchronizer()->addFuture(future); } void PythonRunConfigurationPrivate::handlePySidePackageInfo(const PipPackageInfo &pySideInfo, diff --git a/src/plugins/vcsbase/vcsbasediffeditorcontroller.cpp b/src/plugins/vcsbase/vcsbasediffeditorcontroller.cpp index dbc220302b3..0735fee7296 100644 --- a/src/plugins/vcsbase/vcsbasediffeditorcontroller.cpp +++ b/src/plugins/vcsbase/vcsbasediffeditorcontroller.cpp @@ -2,7 +2,8 @@ // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 #include "vcsbasediffeditorcontroller.h" -#include "vcsplugin.h" + +#include #include #include @@ -52,8 +53,8 @@ Tasking::TaskItem VcsBaseDiffEditorController::postProcessTask() QTC_ASSERT(storage, qWarning("Using postProcessTask() requires putting inputStorage() " "into task tree's root group.")); const QString inputData = storage ? *storage : QString(); + async.setFutureSynchronizer(ExtensionSystem::PluginManager::futureSynchronizer()); async.setConcurrentCallData(&DiffUtils::readPatchWithPromise, inputData); - async.setFutureSynchronizer(Internal::VcsPlugin::futureSynchronizer()); }; const auto onDiffProcessorDone = [this](const AsyncTask> &async) { setDiffFiles(async.isResultAvailable() ? async.result() : QList()); diff --git a/src/plugins/vcsbase/vcsplugin.cpp b/src/plugins/vcsbase/vcsplugin.cpp index e5108942f57..77da3af71c1 100644 --- a/src/plugins/vcsbase/vcsplugin.cpp +++ b/src/plugins/vcsbase/vcsplugin.cpp @@ -23,7 +23,6 @@ #include #include -#include #include #include @@ -41,7 +40,6 @@ class VcsPluginPrivate public: CommonOptionsPage m_settingsPage; QStandardItemModel *m_nickNameModel = nullptr; - FutureSynchronizer m_futureSynchronizer; }; static VcsPlugin *m_instance = nullptr; @@ -123,12 +121,6 @@ CommonVcsSettings &VcsPlugin::settings() const return d->m_settingsPage.settings(); } -FutureSynchronizer *VcsPlugin::futureSynchronizer() -{ - QTC_ASSERT(m_instance, return nullptr); - return &m_instance->d->m_futureSynchronizer; -} - /* Delayed creation/update of the nick name model. */ QStandardItemModel *VcsPlugin::nickNameModel() { diff --git a/src/plugins/vcsbase/vcsplugin.h b/src/plugins/vcsbase/vcsplugin.h index 83157fc1408..99c3d74bbe8 100644 --- a/src/plugins/vcsbase/vcsplugin.h +++ b/src/plugins/vcsbase/vcsplugin.h @@ -11,8 +11,6 @@ QT_BEGIN_NAMESPACE class QStandardItemModel; QT_END_NAMESPACE -namespace Utils { class FutureSynchronizer; } - namespace VcsBase { class VcsBaseSubmitEditor; @@ -36,8 +34,6 @@ public: CommonVcsSettings &settings() const; - static Utils::FutureSynchronizer *futureSynchronizer(); - // Model of user nick names used for the submit // editor. Stored centrally here to achieve delayed // initialization and updating on settings change.