From c68e90ec5cf4ed7cdf03a9ee00610ad233ee1e13 Mon Sep 17 00:00:00 2001 From: hjk Date: Tue, 10 Sep 2013 17:24:15 +0200 Subject: [PATCH] QmlPuppet: save a few function calls Change-Id: Ic73b8bb417c2bf40af6146fe781c206266d3ecf8 Reviewed-by: Marco Bubke --- .../instances/nodeinstanceclientproxy.cpp | 38 ++++++++++--------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/share/qtcreator/qml/qmlpuppet/instances/nodeinstanceclientproxy.cpp b/share/qtcreator/qml/qmlpuppet/instances/nodeinstanceclientproxy.cpp index 9cfdba4f098..6617308a7b5 100644 --- a/share/qtcreator/qml/qmlpuppet/instances/nodeinstanceclientproxy.cpp +++ b/share/qtcreator/qml/qmlpuppet/instances/nodeinstanceclientproxy.cpp @@ -427,41 +427,43 @@ void NodeInstanceClientProxy::dispatchCommand(const QVariant &command) static const int tokenCommandType = QMetaType::type("TokenCommand"); static const int endPuppetCommandType = QMetaType::type("EndPuppetCommand"); - if (command.userType() == createInstancesCommandType) + const int commandType = command.userType(); + + if (commandType == createInstancesCommandType) createInstances(command.value()); - else if (command.userType() == changeFileUrlCommandType) + else if (commandType == changeFileUrlCommandType) changeFileUrl(command.value()); - else if (command.userType() == createSceneCommandType) + else if (commandType == createSceneCommandType) createScene(command.value()); - else if (command.userType() == clearSceneCommandType) + else if (commandType == clearSceneCommandType) clearScene(command.value()); - else if (command.userType() == removeInstancesCommandType) + else if (commandType == removeInstancesCommandType) removeInstances(command.value()); - else if (command.userType() == removePropertiesCommandType) + else if (commandType == removePropertiesCommandType) removeProperties(command.value()); - else if (command.userType() == changeBindingsCommandType) + else if (commandType == changeBindingsCommandType) changePropertyBindings(command.value()); - else if (command.userType() == changeValuesCommandType) + else if (commandType == changeValuesCommandType) changePropertyValues(command.value()); - else if (command.userType() == changeAuxiliaryCommandType) + else if (commandType == changeAuxiliaryCommandType) changeAuxiliaryValues(command.value()); - else if (command.userType() == reparentInstancesCommandType) + else if (commandType == reparentInstancesCommandType) reparentInstances(command.value()); - else if (command.userType() == changeIdsCommandType) + else if (commandType == changeIdsCommandType) changeIds(command.value()); - else if (command.userType() == changeStateCommandType) + else if (commandType == changeStateCommandType) changeState(command.value()); - else if (command.userType() == completeComponentCommandType) + else if (commandType == completeComponentCommandType) completeComponent(command.value()); - else if (command.userType() == changeNodeSourceCommandType) + else if (commandType == changeNodeSourceCommandType) changeNodeSource(command.value()); - else if (command.userType() == removeSharedMemoryCommandType) + else if (commandType == removeSharedMemoryCommandType) removeSharedMemory(command.value()); - else if (command.userType() == tokenCommandType) + else if (commandType == tokenCommandType) redirectToken(command.value()); - else if (command.userType() == endPuppetCommandType) + else if (commandType == endPuppetCommandType) redirectToken(command.value()); - else if (command.userType() == synchronizeCommandType) { + else if (commandType == synchronizeCommandType) { SynchronizeCommand synchronizeCommand = command.value(); m_synchronizeId = synchronizeCommand.synchronizeId(); } else {