feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QtcProcess: Introduce a way to track long-running blocking processes

Browse Source 
...in the main thread.

Set QTC_PROCESS_THRESHOLD (in ms) to receive warnings for them.

Change-Id: Ia9e9c14b5ca339bfa2be82930518f988f56620c2
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Orgad Shaneh
2023-02-10 16:09:49 +02:00
committed by Orgad Shaneh
parent a8bc009595
commit c72638ed74
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/libs/utils/qtcprocess.cpp
View File

@@ -1730,6 +1730,10 @@ void QtcProcess::runBlocking(EventLoopMode eventLoopMode)
// Attach a dynamic property with info about blocking type // Attach a dynamic property with info about blocking type
d->storeEventLoopDebugInfo(int(eventLoopMode)); d->storeEventLoopDebugInfo(int(eventLoopMode));
QDateTime startTime;
static const int blockingThresholdMs = qtcEnvironmentVariableIntValue("QTC_PROCESS_THRESHOLD");
if (blockingThresholdMs > 0 && isMainThread())
startTime = QDateTime::currentDateTime();
QtcProcess::start(); QtcProcess::start();
// Remove the dynamic property so that it's not reused in subseqent start() // Remove the dynamic property so that it's not reused in subseqent start()
@@ -1773,6 +1777,13 @@ void QtcProcess::runBlocking(EventLoopMode eventLoopMode)
} }
} }
} }
if (blockingThresholdMs > 0) {
const int timeDiff = startTime.msecsTo(QDateTime::currentDateTime());
if (timeDiff > blockingThresholdMs && isMainThread()) {
qWarning() << "Blocking process " << d->m_setup.m_commandLine << "took" << timeDiff
<< "ms, longer than threshold" << blockingThresholdMs;
}
}
} }
void QtcProcess::setStdOutCallback(const TextChannelCallback &callback) void QtcProcess::setStdOutCallback(const TextChannelCallback &callback)