feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove parent argument from IEditor constructor

Browse Source 
Editors are owned by whoever created them via the corresponding editor
factory, usually the EditorManager.

Change-Id: I4432eab1a3a8c38ce1bba6bb10b0f9273695a524
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Eike Ziller
2020-09-24 09:42:16 +02:00
parent aff11855f7
commit c74714da04
7 changed files with 17 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/imageviewer/imageviewer.cpp
View File

@@ -75,17 +75,15 @@ static bool updateButtonIconByTheme(QAbstractButton *button, const QString &name
return false;
}
ImageViewer::ImageViewer(QWidget *parent)
: IEditor(parent),
d(new ImageViewerPrivate)
ImageViewer::ImageViewer()
: d(new ImageViewerPrivate)
{
d->file.reset(new ImageViewerFile);
ctor();
}
ImageViewer::ImageViewer(const QSharedPointer<ImageViewerFile> &document, QWidget *parent)
: IEditor(parent),
d(new ImageViewerPrivate)
ImageViewer::ImageViewer(const QSharedPointer<ImageViewerFile> &document)
: d(new ImageViewerPrivate)
{
d->file = document;
ctor();

4
src/plugins/imageviewer/imageviewer.h
View File

@@ -46,7 +46,7 @@ class ImageViewer : public Core::IEditor
Q_OBJECT
public:
explicit ImageViewer(QWidget *parent = nullptr);
ImageViewer();
~ImageViewer() override;
Core::IDocument *document() const override;
@@ -69,7 +69,7 @@ public:
void togglePlay();
private:
ImageViewer(const QSharedPointer<ImageViewerFile> &document, QWidget *parent = nullptr);
ImageViewer(const QSharedPointer<ImageViewerFile> &document);
void ctor();
void playToggled();
void updatePauseAction();