feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove parent argument from IEditor constructor

Browse Source 
Editors are owned by whoever created them via the corresponding editor
factory, usually the EditorManager.

Change-Id: I4432eab1a3a8c38ce1bba6bb10b0f9273695a524
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Eike Ziller
2020-09-24 09:42:16 +02:00
parent aff11855f7
commit c74714da04
7 changed files with 17 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/modeleditor/modeleditor.cpp
View File

@@ -141,16 +141,15 @@ public:
QAction *syncEachOtherAction = nullptr;
};
ModelEditor::ModelEditor(UiController *uiController, ActionHandler *actionHandler, QWidget *parent)
: IEditor(parent),
d(new ModelEditorPrivate)
ModelEditor::ModelEditor(UiController *uiController, ActionHandler *actionHandler)
: d(new ModelEditorPrivate)
{
setContext(Core::Context(Constants::MODEL_EDITOR_ID));
d->uiController = uiController;
d->actionHandler = actionHandler;
d->document = new ModelDocument(this);
connect(d->document, &ModelDocument::contentSet, this, &ModelEditor::onContentSet);
init(parent);
init();
}
ModelEditor::~ModelEditor()
@@ -206,13 +205,13 @@ bool ModelEditor::restoreState(const QByteArray &state)
return false;
}
void ModelEditor::init(QWidget *parent)
void ModelEditor::init()
{
// create and configure properties view
d->propertiesView = new qmt::PropertiesView(this);
// create and configure editor ui
d->rightSplitter = new Core::MiniSplitter(parent);
d->rightSplitter = new Core::MiniSplitter;
connect(d->rightSplitter, &QSplitter::splitterMoved,
this, &ModelEditor::onRightSplitterMoved);
connect(d->uiController, &UiController::rightSplitterChanged,