feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BareMetal: Don't check QtcProcess exit code

Browse Source 
This is already baked into QtcProcess::Result.

Change-Id: Ia601c633dd70be375b641208a471792b0b5eceff
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2021-05-28 13:31:50 +02:00
parent 0ba4338467
commit c756d8d2d5
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/baremetal/iarewtoolchain.cpp
View File

@@ -113,7 +113,7 @@ static Macros dumpPredefinedMacros(const FilePath &compiler, const QStringList &
cpp.setCommand(cmd); cpp.setCommand(cmd);
cpp.runBlocking(); cpp.runBlocking();
if (cpp.result() != QtcProcess::FinishedWithSuccess || cpp.exitCode() != 0) { if (cpp.result() != QtcProcess::FinishedWithSuccess) {
qWarning() << cpp.exitMessage(); qWarning() << cpp.exitMessage();
return {}; return {};
} }

2
src/plugins/baremetal/keiltoolchain.cpp
View File

@@ -287,7 +287,7 @@ static Macros dumpArmPredefinedMacros(const FilePath &compiler, const QStringLis
cpp.setCommand({compiler, args}); cpp.setCommand({compiler, args});
cpp.runBlocking(); cpp.runBlocking();
if (cpp.result() != QtcProcess::FinishedWithSuccess || cpp.exitCode() != 0) { if (cpp.result() != QtcProcess::FinishedWithSuccess) {
qWarning() << cpp.exitMessage(); qWarning() << cpp.exitMessage();
return {}; return {};
} }

4
src/plugins/baremetal/sdcctoolchain.cpp
View File

@@ -93,7 +93,7 @@ static Macros dumpPredefinedMacros(const FilePath &compiler, const Environment &
cpp.setCommand({compiler, {compilerTargetFlag(abi), "-dM", "-E", fakeIn.fileName()}}); cpp.setCommand({compiler, {compilerTargetFlag(abi), "-dM", "-E", fakeIn.fileName()}});
cpp.runBlocking(); cpp.runBlocking();
if (cpp.result() != QtcProcess::FinishedWithSuccess || cpp.exitCode() != 0) { if (cpp.result() != QtcProcess::FinishedWithSuccess) {
qWarning() << cpp.exitMessage(); qWarning() << cpp.exitMessage();
return {}; return {};
} }
@@ -114,7 +114,7 @@ static HeaderPaths dumpHeaderPaths(const FilePath &compiler, const Environment &
cpp.setCommand({compiler, {compilerTargetFlag(abi), "--print-search-dirs"}}); cpp.setCommand({compiler, {compilerTargetFlag(abi), "--print-search-dirs"}});
cpp.runBlocking(); cpp.runBlocking();
if (cpp.result() != QtcProcess::FinishedWithSuccess || cpp.exitCode() != 0) { if (cpp.result() != QtcProcess::FinishedWithSuccess) {
qWarning() << cpp.exitMessage(); qWarning() << cpp.exitMessage();
return {}; return {};
} }