Core: Provide empty implementation for IOptionPageWidget::finish()

Having it pure virtual only lead to a lot of unnecessary
re-implementation.

Change-Id: I37f71d1a160e21b93c7c73a6304b0eb6d5f0441d
Reviewed-by: Eike Ziller <eike.ziller@qt.io>

src/plugins/android/androidsettingswidget.cpp

@@ -99,7 +99,6 @@ public:
 
 private:
     void apply() final { saveSettings(); }
-    void finish() final {}
 
     void saveSettings();
     void validateJdk();

src/plugins/autotest/boost/boosttestsettingspage.cpp

@@ -42,7 +42,6 @@ public:
     explicit BoostTestSettingsWidget(QSharedPointer<BoostTestSettings> settings);
 
     void apply() final;
-    void finish() final {}
 
     void setSettings(const BoostTestSettings &settings);
     BoostTestSettings settings() const;

src/plugins/autotest/gtest/gtestsettingspage.cpp

@@ -50,7 +50,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final {}
 
     Ui::GTestSettingsPage m_ui;
     QString m_currentGTestFilter;

src/plugins/autotest/qtest/qttestsettingspage.cpp

@@ -44,7 +44,6 @@ public:
     explicit QtTestSettingsWidget(QSharedPointer<QtTestSettings> settings);
 
     void apply() final;
-    void finish() final {}
 
 private:
     Ui::QtTestSettingsPage m_ui;

src/plugins/baremetal/debugserverproviderssettingspage.cpp

@@ -277,7 +277,6 @@ public:
     DebugServerProvidersSettingsWidget();
 
     void apply() final { m_model.apply(); }
-    void finish() final {}
 
     void providerSelectionChanged();
     void removeProvider();

src/plugins/beautifier/artisticstyle/artisticstyleoptionspage.cpp

@@ -45,7 +45,6 @@ public:
     explicit ArtisticStyleOptionsPageWidget(ArtisticStyleSettings *settings);
 
     void apply() final;
-    void finish() final {}
 
 private:
     Ui::ArtisticStyleOptionsPage ui;

src/plugins/beautifier/clangformat/clangformatoptionspage.cpp

@@ -44,7 +44,6 @@ public:
     explicit ClangFormatOptionsPageWidget(ClangFormatSettings *settings);
 
     void apply() final;
-    void finish() final {}
 
 private:
     Ui::ClangFormatOptionsPage ui;

src/plugins/beautifier/generaloptionspage.cpp

@@ -39,7 +39,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final {}
 
     Ui::GeneralOptionsPage ui;
 };

src/plugins/beautifier/uncrustify/uncrustifyoptionspage.cpp

@@ -45,7 +45,6 @@ public:
     explicit UncrustifyOptionsPageWidget(UncrustifySettings *settings);
 
     void apply() final;
-    void finish() final {}
 
 private:
     Ui::UncrustifyOptionsPage ui;

src/plugins/clangtools/settingswidget.h

@@ -51,7 +51,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final {};
 
     std::unique_ptr<Ui::SettingsWidget> m_ui;
     ClangToolsSettings *m_settings;

src/plugins/clearcase/settingspage.cpp

@@ -52,7 +52,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final { }
 
     Ui::SettingsPage m_ui;
 };

src/plugins/cmakeprojectmanager/cmakesettingspage.cpp

@@ -590,7 +590,6 @@ public:
     }
 
     void apply() final;
-    void finish() final {}
 
     void cloneCMakeTool();
     void addCMakeTool();

src/plugins/cmakeprojectmanager/cmakespecificsettingspage.cpp

@@ -41,7 +41,6 @@ public:
     explicit CMakeSpecificSettingWidget(CMakeSpecificSettings *settings);
 
     void apply() final;
-    void finish() final {}
 
 private:
     Ui::CMakeSpecificSettingForm m_ui;

src/plugins/coreplugin/dialogs/ioptionspage.h

@@ -42,7 +42,7 @@ class CORE_EXPORT IOptionsPageWidget : public QWidget
 {
 public:
     virtual void apply() = 0;
-    virtual void finish() = 0;
+    virtual void finish() {}
 };
 
 class CORE_EXPORT IOptionsPage : public QObject

src/plugins/coreplugin/systemsettings.cpp

@@ -157,7 +157,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final {}
 
     void showHelpForFileBrowser();
     void resetFileBrowser();

src/plugins/help/docsettingspage.cpp

@@ -166,7 +166,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final {}
 
     void addDocumentation();
 

src/plugins/ios/iossettingswidget.h

@@ -45,7 +45,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final {}
 
     void saveSettings();
 

src/plugins/macros/macrooptionswidget.h

@@ -50,7 +50,6 @@ public:
     void initialize();
 
     void apply() final;
-    void finish() final {}
 
 private:
     void remove();

src/plugins/mcusupport/mcusupportoptionspage.cpp

@@ -64,7 +64,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final {}
 
     void showEvent(QShowEvent *event) final;
 

src/plugins/projectexplorer/appoutputpane.cpp

@@ -877,8 +877,6 @@ public:
         ProjectExplorerPlugin::setAppOutputSettings(s);
     }
 
-    void finish() final {}
-
 private:
     QCheckBox m_wrapOutputCheckBox;
     QCheckBox m_cleanOldOutputCheckBox;

src/plugins/projectexplorer/buildpropertiessettingspage.cpp

@@ -73,8 +73,6 @@ public:
         ProjectExplorerPlugin::setBuildPropertiesSettings(s);
     }
 
-    void finish() final {}
-
 private:
     QComboBox m_separateDebugInfoComboBox;
     QComboBox m_qmlDebuggingComboBox;

src/plugins/projectexplorer/compileoutputwindow.cpp

@@ -402,8 +402,6 @@ public:
         BuildManager::setCompileOutputSettings(s);
     }
 
-    void finish() final {}
-
 private:
     QCheckBox m_wrapOutputCheckBox;
     QCheckBox m_popUpCheckBox;

src/plugins/projectexplorer/devicesupport/devicesettingswidget.h

@@ -56,7 +56,6 @@ public:
 
 private:
     void apply() final { saveSettings(); }
-    void finish() final {}
 
     void saveSettings();
 

src/plugins/projectexplorer/devicesupport/sshsettingspage.cpp

@@ -52,7 +52,6 @@ public:
 
 private:
     void apply() final { saveSettings(); }
-    void finish() final {}
 
     void setupConnectionSharingCheckBox();
     void setupConnectionSharingSpinBox();

src/plugins/qnx/qnxsettingspage.cpp

@@ -67,7 +67,6 @@ public:
     };
 
     void apply() final;
-    void finish() final {}
 
     void addConfiguration();
     void removeConfiguration();

src/plugins/qtsupport/codegensettingspage.h

@@ -43,7 +43,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final {}
 
     int uiEmbedding() const;
     void setUiEmbedding(int);

src/plugins/qtsupport/qtoptionspage.cpp

@@ -182,7 +182,6 @@ public:
 
 private:
     void apply() final;
-    void finish() final {}
 
     void updateDescriptionLabel();
     void userChangedCurrentVersion();

src/plugins/vcsbase/vcsbaseoptionspage.h

@@ -56,7 +56,6 @@ public:
     VcsClientOptionsPageWidget();
 
     void apply() override {}
-    void finish() override {}
 
     virtual void setSettings(const VcsBaseClientSettings &s) = 0;
     virtual VcsBaseClientSettings settings() const = 0;