From c7aa3a960577cb4f9ec7fa4cdf53366152d1bc9d Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Tue, 5 Jul 2022 12:15:50 +0200
Subject: [PATCH] AvdDialog: Connect to watcher before setting a future

This fixes the runtime warning:
"QFutureWatcher::connect: connecting after calling
setFuture() is likely to produce race".

Change-Id: I5c54ec10cef6bfd43a905e4e48fea05cb7b49297
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
---
 src/plugins/android/avddialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/plugins/android/avddialog.cpp b/src/plugins/android/avddialog.cpp
index b92f4cedf84..4f0f8e8a4a4 100644
--- a/src/plugins/android/avddialog.cpp
+++ b/src/plugins/android/avddialog.cpp
@@ -107,13 +107,13 @@ int AvdDialog::exec()
 
         const AndroidAvdManager avdManager = AndroidAvdManager(m_androidConfig);
         QFutureWatcher<CreateAvdInfo> createAvdFutureWatcher;
-        createAvdFutureWatcher.setFuture(avdManager.createAvd(result));
 
         QEventLoop loop;
         QObject::connect(&createAvdFutureWatcher, &QFutureWatcher<CreateAvdInfo>::finished,
                          &loop, &QEventLoop::quit);
         QObject::connect(&createAvdFutureWatcher, &QFutureWatcher<CreateAvdInfo>::canceled,
                          &loop, &QEventLoop::quit);
+        createAvdFutureWatcher.setFuture(avdManager.createAvd(result));
         loop.exec(QEventLoop::ExcludeUserInputEvents);
 
         const QFuture<CreateAvdInfo> future = createAvdFutureWatcher.future();