feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppTools: Remove dependency of RawProjectPart to ProjectFile

Browse Source 
The feature to category files to ProjectFiles was used by the qmake
project manager to specify if the file is "active", and by the Qbs
project manager to avoid unnecessary MIME type checking.

Make these two different use-cases explicit in the API.

Change-Id: Ia5a7da37f100149366fc75060fe04687e15f2bd3
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
Eike Ziller
2019-08-28 12:23:37 +02:00
parent b4dd2ea2cc
commit c7e3bbcd11
10 changed files with 78 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/cpptools/cpprawprojectpart.h
View File

@@ -58,9 +58,12 @@ public:
void setConfigFileName(const QString &configFileName);
void setCallGroupId(const QString &id);
// FileClassifier must be thread-safe.
using FileClassifier = std::function<ProjectFile(const QString &filePath)>;
void setFiles(const QStringList &files, const FileClassifier &fileClassifier = FileClassifier());
// FileIsActive and GetMimeType must be thread-safe.
using FileIsActive = std::function<bool(const QString &filePath)>;
using GetMimeType = std::function<QString(const QString &filePath)>;
void setFiles(const QStringList &files,
const FileIsActive &fileIsActive = {},
const GetMimeType &getMimeType = {});
static ProjectExplorer::HeaderPath frameworkDetectionHeuristic(const ProjectExplorer::HeaderPath &header);
void setHeaderPaths(const ProjectExplorer::HeaderPaths &headerPaths);
void setIncludePaths(const QStringList &includePaths);
@@ -86,7 +89,8 @@ public:
// Files
QStringList files;
FileClassifier fileClassifier;
FileIsActive fileIsActive;
GetMimeType getMimeType;
QStringList precompiledHeaders;
ProjectExplorer::HeaderPaths headerPaths;
QString projectConfigFile; // Generic Project Manager only