feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Consolidate breakpoint search

Browse Source 
We already have a concept of Context when action on editor events,
use that directly when searching an (almost) matching breakpoint
instead of translating it into breakpoint manager's interface
language.

This also centralizes the guesswork for non-exact matches in one
place, making it easier to fix currently wrong matches later.

Change-Id: I5579e7e01792d425cad4ccf1dbcbbd1bd56c84ec
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-08-22 17:35:12 +02:00
parent 4192d7d62f
commit c7f0285c4c
3 changed files with 34 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/debugger/breakhandler.h
View File

@@ -78,8 +78,6 @@ public:
void updateLineNumber(int lineNumber);
void updateFileName(const Utils::FileName &fileName);
bool isLocatedAt(const QString &fileName, int lineNumber, bool useMarkerPosition) const;
QString displayName() const;
QString markerFileName() const;
QString toolTip() const;
@@ -296,12 +294,7 @@ public:
static const GlobalBreakpoints globalBreakpoints();
static GlobalBreakpoint createBreakpoint(const BreakpointParameters &data);
static GlobalBreakpoint findBreakpointByLocation(const ContextData &location);
// Find a breakpoint matching approximately the data in needle.
static GlobalBreakpoint findSimilarBreakpoint(const BreakpointParameters &needle);
static GlobalBreakpoint findWatchpoint(const BreakpointParameters &data);
static GlobalBreakpoint findBreakpointByFunction(const QString &functionName);
static GlobalBreakpoint findBreakpointFromContext(const ContextData &location);
static void claimBreakpointsForEngine(DebuggerEngine *engine);
static void toggleBreakpoint(const ContextData &location, const QString &tracePointMessage = QString());