feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ShellCommand: De-virtualize addTask()

Browse Source 
Provide executedAsync() signal instead.

Change-Id: I8f04dc90875e5f27827ea553a9f23f41656cc4db
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Jarek Kobus
2022-07-13 23:21:33 +02:00
parent 85071d8e8d
commit c7f24f9f13
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libs/utils/shellcommand.cpp
View File

@@ -209,8 +209,7 @@ void ShellCommand::execute()
QFuture<void> task = runAsync(&ShellCommand::run, this);
d->m_watcher.setFuture(task);
if (!(d->m_flags & SuppressCommandLogging))
addTask(task);
emit executedAsync(task);
}
void ShellCommand::abort()
@@ -224,11 +223,6 @@ void ShellCommand::cancel()
emit terminate();
}
void ShellCommand::addTask(QFuture<void> &future)
{
Q_UNUSED(future)
}
void ShellCommand::postRunCommand(const FilePath &workingDirectory)
{
Q_UNUSED(workingDirectory)