feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VCS: Do not write defaults to settings

Browse Source 
Saves useless entries in settings file and makes it possible to change
defaults later.

Task-number: QTCREATORBUG-24762
Change-Id: Iee7d39f2bf5d8de6903ca914ea533a678fad62f8
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Eike Ziller
2021-02-16 14:51:16 +01:00
parent d2f7bea0b6
commit c87284356c
5 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/vcsbase/commonvcssettings.cpp
View File

@@ -64,15 +64,13 @@ CommonVcsSettings::CommonVcsSettings() :
void CommonVcsSettings::toSettings(Utils::QtcSettings *s) const
{
s->beginGroup(QLatin1String(settingsGroupC));
s->setValue(QLatin1String(nickNameMailMapKeyC), nickNameMailMap);
s->setValue(QLatin1String(nickNameFieldListFileKeyC), nickNameFieldListFile);
s->setValue(QLatin1String(submitMessageCheckScriptKeyC), submitMessageCheckScript);
s->setValue(QLatin1String(lineWrapKeyC), lineWrap);
s->setValue(QLatin1String(lineWrapWidthKeyC), lineWrapWidth);
s->setValueWithDefault(QLatin1String(sshPasswordPromptKeyC),
sshPasswordPrompt,
sshPasswordPromptDefault());
s->beginGroup(settingsGroupC);
s->setValueWithDefault(nickNameMailMapKeyC, nickNameMailMap);
s->setValueWithDefault(nickNameFieldListFileKeyC, nickNameFieldListFile);
s->setValueWithDefault(submitMessageCheckScriptKeyC, submitMessageCheckScript);
s->setValueWithDefault(lineWrapKeyC, lineWrap, lineWrapDefault);
s->setValueWithDefault(lineWrapWidthKeyC, lineWrapWidth, lineWrapWidthDefault);
s->setValueWithDefault(sshPasswordPromptKeyC, sshPasswordPrompt, sshPasswordPromptDefault());
s->endGroup();
}