From c8affd6e747c4dfdf2ef03dca67be14d78b228a6 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Wed, 12 Jul 2017 14:33:18 +0200 Subject: [PATCH] Help: Remove trivial slots Use one-line lambdas Change-Id: I85d1fe33283b6c517a1942d833d6b127002540f5 Reviewed-by: Jarek Kobus --- src/plugins/help/helpplugin.cpp | 18 ++++++------------ src/plugins/help/helpplugin.h | 2 -- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/src/plugins/help/helpplugin.cpp b/src/plugins/help/helpplugin.cpp index 45765dacaad..e20b4cd8419 100644 --- a/src/plugins/help/helpplugin.cpp +++ b/src/plugins/help/helpplugin.cpp @@ -200,12 +200,16 @@ bool HelpPlugin::initialize(const QStringList &arguments, QString *error) action = new QAction(tr("Technical Support"), this); cmd = ActionManager::registerAction(action, "Help.TechSupport"); ActionManager::actionContainer(Core::Constants::M_HELP)->addAction(cmd, Core::Constants::G_HELP_SUPPORT); - connect(action, &QAction::triggered, this, &HelpPlugin::slotOpenSupportPage); + connect(action, &QAction::triggered, this, [this] { + showLinkInHelpMode(QUrl("qthelp://org.qt-project.qtcreator/doc/technical-support.html")); + }); action = new QAction(tr("Report Bug..."), this); cmd = ActionManager::registerAction(action, "Help.ReportBug"); ActionManager::actionContainer(Core::Constants::M_HELP)->addAction(cmd, Core::Constants::G_HELP_SUPPORT); - connect(action, &QAction::triggered, this, &HelpPlugin::slotReportBug); + connect(action, &QAction::triggered, this, [] { + QDesktopServices::openUrl(QUrl("https://bugreports.qt.io")); + }); action = new QAction(tr("System Information..."), this); cmd = ActionManager::registerAction(action, "Help.SystemInformation"); @@ -638,16 +642,6 @@ void HelpPlugin::handleHelpRequest(const QUrl &url, HelpManager::HelpViewerLocat ICore::raiseWindow(viewer); } -void HelpPlugin::slotOpenSupportPage() -{ - showLinkInHelpMode(QUrl("qthelp://org.qt-project.qtcreator/doc/technical-support.html")); -} - -void HelpPlugin::slotReportBug() -{ - QDesktopServices::openUrl(QUrl("https://bugreports.qt.io")); -} - class DialogClosingOnEscape : public QDialog { public: diff --git a/src/plugins/help/helpplugin.h b/src/plugins/help/helpplugin.h index 4393e7953c8..07b31f12a8a 100644 --- a/src/plugins/help/helpplugin.h +++ b/src/plugins/help/helpplugin.h @@ -98,8 +98,6 @@ private: void highlightSearchTermsInContextHelp(); void handleHelpRequest(const QUrl &url, Core::HelpManager::HelpViewerLocation location); - void slotOpenSupportPage(); - void slotReportBug(); void slotSystemInformation(); void resetFilter();