feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Base JobQueue on translation unit

Browse Source 
This enables a job per translation unit instead of per document.

This does not change any behavior yet.

Change-Id: Iafb8dab5da32b53dbb3010c16241bf89cbb81b38
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Nikolai Kosjar
2016-09-13 13:57:08 +02:00
parent 8d443b40b7
commit c8cec2dd0d
17 changed files with 108 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/tools/clangbackend/ipcsource/clangcompletecodejob.cpp
View File

@@ -50,10 +50,10 @@ static CompleteCodeJob::AsyncResult runAsyncHelper(const TranslationUnit &transl
return asyncResult;
}
bool CompleteCodeJob::prepareAsyncRun()
IAsyncJob::AsyncPrepareResult CompleteCodeJob::prepareAsyncRun()
{
const JobRequest jobRequest = context().jobRequest;
QTC_ASSERT(jobRequest.type == JobRequest::Type::CompleteCode, return false);
QTC_ASSERT(jobRequest.type == JobRequest::Type::CompleteCode, return AsyncPrepareResult());
try {
m_pinnedDocument = context().documentForJobRequest();
@@ -65,14 +65,12 @@ bool CompleteCodeJob::prepareAsyncRun()
setRunner([translationUnit, unsavedFiles, line, column]() {
return runAsyncHelper(translationUnit, unsavedFiles, line, column);
});
return AsyncPrepareResult{translationUnit.id()};
} catch (const std::exception &exception) {
qWarning() << "Error in CompleteCodeJob::prepareAsyncRun:" << exception.what();
return false;
return AsyncPrepareResult();
}
return true;
}
void CompleteCodeJob::finalizeAsyncRun()

2
src/tools/clangbackend/ipcsource/clangcompletecodejob.h
View File

@@ -43,7 +43,7 @@ class CompleteCodeJob : public AsyncJob<CompleteCodeJobResult>
public:
using AsyncResult = CompleteCodeJobResult;
bool prepareAsyncRun() override;
AsyncPrepareResult prepareAsyncRun() override;
void finalizeAsyncRun() override;
private:

9
src/tools/clangbackend/ipcsource/clangcreateinitialdocumentpreamblejob.cpp
View File

@@ -39,10 +39,10 @@ static void runAsyncHelper(const TranslationUnit &translationUnit,
translationUnit.reparse(translationUnitUpdateInput);
}
bool CreateInitialDocumentPreambleJob::prepareAsyncRun()
IAsyncJob::AsyncPrepareResult CreateInitialDocumentPreambleJob::prepareAsyncRun()
{
const JobRequest jobRequest = context().jobRequest;
QTC_ASSERT(jobRequest.type == JobRequest::Type::CreateInitialDocumentPreamble, return false);
QTC_ASSERT(jobRequest.type == JobRequest::Type::CreateInitialDocumentPreamble, return AsyncPrepareResult());
try {
m_pinnedDocument = context().documentForJobRequest();
@@ -53,14 +53,13 @@ bool CreateInitialDocumentPreambleJob::prepareAsyncRun()
setRunner([translationUnit, updateInput]() {
return runAsyncHelper(translationUnit, updateInput);
});
return AsyncPrepareResult{translationUnit.id()};
} catch (const std::exception &exception) {
qWarning() << "Error in CreateInitialDocumentPreambleJob::prepareAsyncRun:"
<< exception.what();
return false;
return AsyncPrepareResult();
}
return true;
}
void CreateInitialDocumentPreambleJob::finalizeAsyncRun()

2
src/tools/clangbackend/ipcsource/clangcreateinitialdocumentpreamblejob.h
View File

@@ -33,7 +33,7 @@ namespace ClangBackEnd {
class CreateInitialDocumentPreambleJob : public AsyncJob<void>
{
public:
bool prepareAsyncRun() override;
AsyncPrepareResult prepareAsyncRun() override;
void finalizeAsyncRun() override;
private:

7
src/tools/clangbackend/ipcsource/clangiasyncjob.h
View File

@@ -41,6 +41,11 @@ class IAsyncJob
public:
static IAsyncJob *create(JobRequest::Type type);
struct AsyncPrepareResult {
operator bool() const { return !translationUnitId.isEmpty(); }
Utf8String translationUnitId;
};
public:
IAsyncJob();
virtual ~IAsyncJob();
@@ -52,7 +57,7 @@ public:
FinishedHandler finishedHandler() const;
void setFinishedHandler(const FinishedHandler &finishedHandler);
virtual bool prepareAsyncRun() = 0;
virtual AsyncPrepareResult prepareAsyncRun() = 0;
virtual QFuture<void> runAsync() = 0;
virtual void finalizeAsyncRun() = 0;

27
src/tools/clangbackend/ipcsource/clangjobqueue.cpp
View File

@@ -27,6 +27,7 @@
#include "clangjobqueue.h"
#include "clangdocument.h"
#include "clangdocuments.h"
#include "clangtranslationunits.h"
#include "projects.h"
#include "unsavedfiles.h"
@@ -164,43 +165,43 @@ void JobQueue::prioritizeRequests()
JobRequests JobQueue::takeJobRequestsToRunNow()
{
JobRequests jobsToRun;
QSet<DocumentId> documentsScheduledForThisRun;
using TranslationUnitIds = QSet<Utf8String>;
TranslationUnitIds translationUnitsScheduledForThisRun;
QMutableVectorIterator<JobRequest> i(m_queue);
while (i.hasNext()) {
const JobRequest &jobRequest = i.next();
const JobRequest &request = i.next();
try {
const Document &document
= m_documents.document(jobRequest.filePath,
jobRequest.projectPartId);
const DocumentId documentId = DocumentId(jobRequest.filePath, jobRequest.projectPartId);
const Document &document = m_documents.document(request.filePath,
request.projectPartId);
if (!document.isUsedByCurrentEditor() && !document.isVisibleInEditor())
continue;
if (documentsScheduledForThisRun.contains(documentId))
const Utf8String id = document.translationUnit(request.preferredTranslationUnit).id();
if (translationUnitsScheduledForThisRun.contains(id))
continue;
if (isJobRunningForDocument(documentId))
if (isJobRunningForTranslationUnit(id))
continue;
documentsScheduledForThisRun.insert(documentId);
jobsToRun += jobRequest;
translationUnitsScheduledForThisRun.insert(id);
jobsToRun += request;
i.remove();
} catch (const std::exception &exception) {
qWarning() << "Error in Jobs::takeJobRequestsToRunNow for"
<< jobRequest << ":" << exception.what();
<< request << ":" << exception.what();
}
}
return jobsToRun;
}
bool JobQueue::isJobRunningForDocument(const JobQueue::DocumentId &documentId)
bool JobQueue::isJobRunningForTranslationUnit(const Utf8String &translationUnitId)
{
if (m_isJobRunningHandler)
return m_isJobRunningHandler(documentId.first, documentId.second);
return m_isJobRunningHandler(translationUnitId);
return false;
}

5
src/tools/clangbackend/ipcsource/clangjobqueue.h
View File

@@ -43,7 +43,7 @@ public:
JobRequests processQueue();
using IsJobRunningHandler = std::function<bool(const Utf8String &, const Utf8String &)>;
using IsJobRunningHandler = std::function<bool(const Utf8String &)>;
void setIsJobRunningHandler(const IsJobRunningHandler &isJobRunningHandler);
public: // for tests
@@ -52,8 +52,7 @@ public: // for tests
void prioritizeRequests();
private:
using DocumentId = QPair<Utf8String, Utf8String>;
bool isJobRunningForDocument(const DocumentId &documentId);
bool isJobRunningForTranslationUnit(const Utf8String &translationUnitId);
JobRequests takeJobRequestsToRunNow();
void removeOutDatedRequests();
bool isJobRequestOutDated(const JobRequest &jobRequest) const;

20
src/tools/clangbackend/ipcsource/clangjobrequest.cpp
View File

@@ -25,6 +25,8 @@
#include "clangjobrequest.h"
#include <QFileInfo>
namespace ClangBackEnd {
#define RETURN_TEXT_FOR_CASE(enumValue) case JobRequest::Type::enumValue: return #enumValue
@@ -41,6 +43,18 @@ static const char *JobRequestTypeToText(JobRequest::Type type)
}
#undef RETURN_TEXT_FOR_CASE
#define RETURN_TEXT_FOR_CASE(enumValue) case PreferredTranslationUnit::enumValue: return #enumValue
const char *preferredTranslationUnitToText(PreferredTranslationUnit type)
{
switch (type) {
RETURN_TEXT_FOR_CASE(RecentlyParsed);
RETURN_TEXT_FOR_CASE(PreviouslyParsed);
}
return "UnhandledPreferredTranslationUnitType";
}
#undef RETURN_TEXT_FOR_CASE
QDebug operator<<(QDebug debug, JobRequest::Type type)
{
debug << JobRequestTypeToText(type);
@@ -53,12 +67,14 @@ QDebug operator<<(QDebug debug, const JobRequest &jobRequest)
debug.nospace() << "Job<"
<< jobRequest.id
<< ","
<< QFileInfo(jobRequest.filePath).fileName()
<< ","
<< JobRequestTypeToText(jobRequest.type)
<< ","
<< jobRequest.filePath
<< preferredTranslationUnitToText(jobRequest.preferredTranslationUnit)
<< ">";
return debug;
return debug.space();
}
JobRequest::JobRequest()

2
src/tools/clangbackend/ipcsource/clangjobrequest.h
View File

@@ -25,6 +25,7 @@
#pragma once
#include "clangbackend_global.h"
#include "clangclock.h"
#include <utf8string.h>
@@ -73,6 +74,7 @@ public:
TimePoint unsavedFilesChangeTimePoint;
TimePoint projectChangeTimePoint;
uint documentRevision = 0;
PreferredTranslationUnit preferredTranslationUnit = PreferredTranslationUnit::RecentlyParsed;
// For code completion
quint32 line = 0;

21
src/tools/clangbackend/ipcsource/clangjobs.cpp
View File

@@ -45,9 +45,8 @@ Jobs::Jobs(Documents &documents,
, m_client(client)
, m_queue(documents, projectParts)
{
m_queue.setIsJobRunningHandler([this](const Utf8String &filePath,
const Utf8String &projectPartId) {
return isJobRunning(filePath, projectPartId);
m_queue.setIsJobRunningHandler([this](const Utf8String &translationUnitId) {
return isJobRunning(translationUnitId);
});
}
@@ -97,13 +96,15 @@ bool Jobs::runJob(const JobRequest &jobRequest)
JobContext context(jobRequest, &m_documents, &m_unsavedFiles, &m_client);
asyncJob->setContext(context);
if (asyncJob->prepareAsyncRun()) {
qCDebug(jobsLog) << "Running" << jobRequest;
if (const IAsyncJob::AsyncPrepareResult prepareResult = asyncJob->prepareAsyncRun()) {
qCDebug(jobsLog) << "Running" << jobRequest
<< "with TranslationUnit" << prepareResult.translationUnitId;
asyncJob->setFinishedHandler([this](IAsyncJob *asyncJob){ onJobFinished(asyncJob); });
const QFuture<void> future = asyncJob->runAsync();
m_running.insert(asyncJob, RunningJob{jobRequest, future});
const RunningJob runningJob{jobRequest, prepareResult.translationUnitId, future};
m_running.insert(asyncJob, runningJob);
return true;
} else {
qCDebug(jobsLog) << "Preparation failed for " << jobRequest;
@@ -134,12 +135,10 @@ JobRequests Jobs::queue() const
return m_queue.queue();
}
bool Jobs::isJobRunning(const Utf8String &filePath, const Utf8String &projectPartId) const
bool Jobs::isJobRunning(const Utf8String &translationUnitId) const
{
const auto hasJobRequest = [filePath, projectPartId](const RunningJob &runningJob) {
const JobRequest &jobRequest = runningJob.jobRequest;
return filePath == jobRequest.filePath
&& projectPartId == jobRequest.projectPartId;
const auto hasJobRequest = [translationUnitId](const RunningJob &runningJob) {
return runningJob.translationUnitId == translationUnitId;
};
return Utils::anyOf(m_running.values(), hasJobRequest);

3
src/tools/clangbackend/ipcsource/clangjobs.h
View File

@@ -43,6 +43,7 @@ class Jobs
public:
struct RunningJob {
JobRequest jobRequest;
Utf8String translationUnitId;
QFuture<void> future;
};
using RunningJobs = QHash<IAsyncJob *, RunningJob>;
@@ -61,7 +62,7 @@ public:
public /*for tests*/:
QList<RunningJob> runningJobs() const;
JobRequests queue() const;
bool isJobRunning(const Utf8String &filePath, const Utf8String &projectPartId) const;
bool isJobRunning(const Utf8String &translationUnitId) const;
private:
JobRequests runJobs(const JobRequests &jobRequest);

10
src/tools/clangbackend/ipcsource/clangrequestdocumentannotationsjob.cpp
View File

@@ -47,10 +47,11 @@ static RequestDocumentAnnotationsJob::AsyncResult runAsyncHelper(
return asyncResult;
}
bool RequestDocumentAnnotationsJob::prepareAsyncRun()
IAsyncJob::AsyncPrepareResult RequestDocumentAnnotationsJob::prepareAsyncRun()
{
const JobRequest jobRequest = context().jobRequest;
QTC_ASSERT(jobRequest.type == JobRequest::Type::RequestDocumentAnnotations, return false);
QTC_ASSERT(jobRequest.type == JobRequest::Type::RequestDocumentAnnotations,
return AsyncPrepareResult());
try {
m_pinnedDocument = context().documentForJobRequest();
@@ -60,13 +61,12 @@ bool RequestDocumentAnnotationsJob::prepareAsyncRun()
setRunner([translationUnit]() {
return runAsyncHelper(translationUnit);
});
return AsyncPrepareResult{translationUnit.id()};
} catch (const std::exception &exception) {
qWarning() << "Error in RequestDocumentAnnotationsJob::prepareAsyncRun:" << exception.what();
return false;
return AsyncPrepareResult();
}
return true;
}
void RequestDocumentAnnotationsJob::finalizeAsyncRun()

2
src/tools/clangbackend/ipcsource/clangrequestdocumentannotationsjob.h
View File

@@ -46,7 +46,7 @@ class RequestDocumentAnnotationsJob : public AsyncJob<RequestDocumentAnnotations
public:
using AsyncResult = RequestDocumentAnnotationsJobResult;
bool prepareAsyncRun() override;
AsyncPrepareResult prepareAsyncRun() override;
void finalizeAsyncRun() override;
private:

10
src/tools/clangbackend/ipcsource/clangupdatedocumentannotationsjob.cpp
View File

@@ -52,10 +52,11 @@ static UpdateDocumentAnnotationsJob::AsyncResult runAsyncHelper(
return asyncResult;
}
bool UpdateDocumentAnnotationsJob::prepareAsyncRun()
IAsyncJob::AsyncPrepareResult UpdateDocumentAnnotationsJob::prepareAsyncRun()
{
const JobRequest jobRequest = context().jobRequest;
QTC_ASSERT(jobRequest.type == JobRequest::Type::UpdateDocumentAnnotations, return false);
QTC_ASSERT(jobRequest.type == JobRequest::Type::UpdateDocumentAnnotations,
return AsyncPrepareResult());
try {
m_pinnedDocument = context().documentForJobRequest();
@@ -66,13 +67,12 @@ bool UpdateDocumentAnnotationsJob::prepareAsyncRun()
setRunner([translationUnit, updateInput]() {
return runAsyncHelper(translationUnit, updateInput);
});
return AsyncPrepareResult{translationUnit.id()};
} catch (const std::exception &exception) {
qWarning() << "Error in UpdateDocumentAnnotationsJob::prepareAsyncRun:" << exception.what();
return false;
return AsyncPrepareResult();
}
return true;
}
void UpdateDocumentAnnotationsJob::finalizeAsyncRun()

2
src/tools/clangbackend/ipcsource/clangupdatedocumentannotationsjob.h
View File

@@ -49,7 +49,7 @@ class UpdateDocumentAnnotationsJob : public AsyncJob<UpdateDocumentAnnotationsJo
public:
using AsyncResult = UpdateDocumentAnnotationsJobResult;
bool prepareAsyncRun() override;
AsyncPrepareResult prepareAsyncRun() override;
void finalizeAsyncRun() override;
private:

37
tests/unit/unittest/clangjobqueue-test.cpp
View File

@@ -28,6 +28,8 @@
#include <clangdocument.h>
#include <clangdocuments.h>
#include <clangtranslationunit.h>
#include <clangtranslationunits.h>
#include <clangjobs.h>
#include <filecontainer.h>
#include <projectpart.h>
@@ -60,7 +62,9 @@ protected:
Utf8String createTranslationUnitForDeletedFile();
JobRequest createJobRequest(const Utf8String &filePath,
JobRequest::Type type) const;
JobRequest::Type type,
PreferredTranslationUnit preferredTranslationUnit
= PreferredTranslationUnit::RecentlyParsed) const;
void updateDocumentRevision();
void updateUnsavedFiles();
@@ -240,7 +244,7 @@ TEST_F(JobQueue, RunNothingForNotCurrentOrVisibleDocument)
ASSERT_THAT(jobsToRun.size(), Eq(0));
}
TEST_F(JobQueue, RunOnlyOneJobPerDocumentIfMultipleAreInQueue)
TEST_F(JobQueue, RunOnlyOneJobPerTranslationUnitIfMultipleAreInQueue)
{
jobQueue.add(createJobRequest(filePath1, JobRequest::Type::UpdateDocumentAnnotations));
jobQueue.add(createJobRequest(filePath1, JobRequest::Type::UpdateDocumentAnnotations));
@@ -251,12 +255,30 @@ TEST_F(JobQueue, RunOnlyOneJobPerDocumentIfMultipleAreInQueue)
ASSERT_THAT(jobQueue.size(), Eq(1));
}
TEST_F(JobQueue, DoNotRunJobForDocumentThatIsBeingProcessed)
TEST_F(JobQueue, RunJobsForDistinctTranslationUnits)
{
const TranslationUnit initialTu = document.translationUnit();
document.translationUnits().updateParseTimePoint(initialTu.id(), std::chrono::steady_clock::now());
const TranslationUnit alternativeTu = document.translationUnits().createAndAppend();
document.translationUnits().updateParseTimePoint(alternativeTu.id(), std::chrono::steady_clock::now());
jobQueue.add(createJobRequest(filePath1,
JobRequest::Type::UpdateDocumentAnnotations,
PreferredTranslationUnit::RecentlyParsed));
jobQueue.add(createJobRequest(filePath1,
JobRequest::Type::UpdateDocumentAnnotations,
PreferredTranslationUnit::PreviouslyParsed));
const JobRequests jobsToRun = jobQueue.processQueue();
ASSERT_THAT(jobsToRun.size(), Eq(2));
ASSERT_THAT(jobQueue.size(), Eq(0));
}
TEST_F(JobQueue, DoNotRunJobForTranslationUnittThatIsBeingProcessed)
{
jobQueue.add(createJobRequest(filePath1, JobRequest::Type::UpdateDocumentAnnotations));
jobQueue.add(createJobRequest(filePath1, JobRequest::Type::UpdateDocumentAnnotations));
JobRequests jobsToRun = jobQueue.processQueue();
jobQueue.setIsJobRunningHandler([](const Utf8String &, const Utf8String &) {
jobQueue.setIsJobRunningHandler([](const Utf8String &) {
return true;
});
@@ -397,8 +419,10 @@ Utf8String JobQueue::createTranslationUnitForDeletedFile()
return temporaryFilePath;
}
JobRequest JobQueue::createJobRequest(const Utf8String &filePath,
JobRequest::Type type) const
JobRequest JobQueue::createJobRequest(
const Utf8String &filePath,
JobRequest::Type type,
PreferredTranslationUnit preferredTranslationUnit) const
{
JobRequest jobRequest;
jobRequest.type = type;
@@ -407,6 +431,7 @@ JobRequest JobQueue::createJobRequest(const Utf8String &filePath,
jobRequest.projectPartId = projectPartId;
jobRequest.unsavedFilesChangeTimePoint = unsavedFiles.lastChangeTimePoint();
jobRequest.documentRevision = document.documentRevision();
jobRequest.preferredTranslationUnit = preferredTranslationUnit;
jobRequest.projectChangeTimePoint = projects.project(projectPartId).lastChangeTimePoint();
return jobRequest;

2
tests/unit/unittest/clangjobs-test.cpp
View File

@@ -108,7 +108,7 @@ TEST_F(Jobs, IsJobRunning)
jobs.add(createJobRequest(filePath1, JobRequest::Type::UpdateDocumentAnnotations));
jobs.process();
const bool isJobRunning = jobs.isJobRunning(filePath1, projectPartId);
const bool isJobRunning = jobs.isJobRunning(document.translationUnit().id());
ASSERT_TRUE(isJobRunning);
}