feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Introduce AssistProposalItemInterface

Browse Source 
For unit test we need to break every dependency to the TextEditor
Widget etc.. With an abstract interface we can implement it in clang
without relying on unwanted dependencies. It makes it also easier to
compute the values deferred.

Change-Id: I1b313a1625f4e80bd324ab4bf1a7c4f6b690abe9
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>
This commit is contained in:
Marco Bubke
2016-02-01 14:51:01 +01:00
parent e42bf6ebc6
commit c903f4974f
31 changed files with 187 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/texteditor/snippets/snippetassistcollector.cpp
View File

@@ -32,7 +32,7 @@
using namespace TextEditor;
using namespace Internal;
static void appendSnippets(QList<AssistProposalItem *> *items,
static void appendSnippets(QList<AssistProposalItemInterface *> *items,
const QString &groupId,
const QIcon &icon,
int order)
@@ -61,9 +61,9 @@ SnippetAssistCollector::SnippetAssistCollector(const QString &groupId, const QIc
SnippetAssistCollector::~SnippetAssistCollector()
{}
QList<AssistProposalItem *> SnippetAssistCollector::collect() const
QList<AssistProposalItemInterface *> SnippetAssistCollector::collect() const
{
QList<AssistProposalItem *> snippets;
QList<AssistProposalItemInterface *> snippets;
appendSnippets(&snippets, m_groupId, m_icon, m_order);
appendSnippets(&snippets, QLatin1String(Constants::TEXT_SNIPPET_GROUP_ID), m_icon, m_order);
return snippets;

4
src/plugins/texteditor/snippets/snippetassistcollector.h
View File

@@ -34,7 +34,7 @@
namespace TextEditor {
class AssistProposalItem;
class AssistProposalItemInterface;
class TEXTEDITOR_EXPORT SnippetAssistCollector
{
@@ -42,7 +42,7 @@ public:
SnippetAssistCollector(const QString &groupId, const QIcon &icon, int order = 0);
~SnippetAssistCollector();
QList<AssistProposalItem *> collect() const;
QList<AssistProposalItemInterface *> collect() const;
private:
QString m_groupId;