feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove BuildStepList::isNull

Browse Source 
It's not really needed. The Null-ness is equivalent to a failed
fromMap() which we execute on all usage paths anyways.

Change-Id: I72bb7fb55b7f26680fa68da8eef751ca96380ecd
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
hjk
2016-06-15 10:37:51 +02:00
committed by hjk
parent 6e925910b4
commit c94ce7b205
4 changed files with 6 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/projectexplorer/buildsteplist.cpp
View File

@@ -51,8 +51,7 @@ BuildStepList::BuildStepList(QObject *parent, Core::Id id) :
}
BuildStepList::BuildStepList(QObject *parent, BuildStepList *source) :
ProjectConfiguration(parent, source),
m_isNull(source->m_isNull)
ProjectConfiguration(parent, source)
{
setDisplayName(source->displayName());
Q_ASSERT(parent);
@@ -61,13 +60,6 @@ BuildStepList::BuildStepList(QObject *parent, BuildStepList *source) :
// will fail to clone the buildsteps!
}
BuildStepList::BuildStepList(QObject *parent, const QVariantMap &data) :
ProjectConfiguration(parent, Core::Id())
{
Q_ASSERT(parent);
m_isNull = !fromMap(data);
}
BuildStepList::~BuildStepList()
{
qDeleteAll(m_steps);
@@ -84,11 +76,6 @@ QVariantMap BuildStepList::toMap() const
return map;
}
bool BuildStepList::isNull() const
{
return m_isNull;
}
int BuildStepList::count() const
{
return m_steps.count();