feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Remove BuildStepList::isNull

Browse Source 
It's not really needed. The Null-ness is equivalent to a failed
fromMap() which we execute on all usage paths anyways.

Change-Id: I72bb7fb55b7f26680fa68da8eef751ca96380ecd
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
hjk
2016-06-15 10:37:51 +02:00
committed by hjk
parent 6e925910b4
commit c94ce7b205
4 changed files with 6 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/projectexplorer/deployconfiguration.cpp
View File

@@ -116,8 +116,8 @@ bool DeployConfiguration::fromMap(const QVariantMap &map)
QVariantMap data = map.value(QLatin1String(BUILD_STEP_LIST_PREFIX) + QLatin1Char('0')).toMap();
if (!data.isEmpty()) {
delete m_stepList;
m_stepList = new BuildStepList(this, data);
if (m_stepList->isNull()) {
m_stepList = new BuildStepList(this, Core::Id());
if (!m_stepList->fromMap(data)) {
qWarning() << "Failed to restore deploy step list";
delete m_stepList;
m_stepList = 0;