feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Pass Id to BuildStep constructor

Browse Source 
Allows to use constants in fewer places, similar to what e.g.
RunConfiguration does.

Change-Id: I9d049128206c4acf0ce14b06b66d6c090a7c5242
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-12-20 17:05:30 +01:00
parent 2f5365bf61
commit c95bde6f6a
73 changed files with 140 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
View File

@@ -76,8 +76,8 @@ static bool isCurrentExecutableTarget(const QString &target)
return target == ADD_RUNCONFIGURATION_TEXT;
}
CMakeBuildStep::CMakeBuildStep(BuildStepList *bsl) :
AbstractProcessStep(bsl, Constants::CMAKE_BUILD_STEP_ID)
CMakeBuildStep::CMakeBuildStep(BuildStepList *bsl, Core::Id id) :
AbstractProcessStep(bsl, id)
{
m_percentProgress = QRegExp("^\\[\\s*(\\d*)%\\]");
m_ninjaProgress = QRegExp("^\\[\\s*(\\d*)/\\s*(\\d*)");

2
src/plugins/cmakeprojectmanager/cmakebuildstep.h
View File

@@ -56,7 +56,7 @@ class CMakeBuildStep : public ProjectExplorer::AbstractProcessStep
friend class CMakeBuildStepFactory;
public:
explicit CMakeBuildStep(ProjectExplorer::BuildStepList *bsl);
CMakeBuildStep(ProjectExplorer::BuildStepList *bsl, Core::Id id);
CMakeBuildConfiguration *cmakeBuildConfiguration() const;