feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Pass Id to BuildStep constructor

Browse Source 
Allows to use constants in fewer places, similar to what e.g.
RunConfiguration does.

Change-Id: I9d049128206c4acf0ce14b06b66d6c090a7c5242
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-12-20 17:05:30 +01:00
parent 2f5365bf61
commit c95bde6f6a
73 changed files with 140 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/ios/iosbuildstep.cpp
View File

@@ -163,8 +163,8 @@ private:
QLineEdit *m_extraArgumentsLineEdit;
};
IosBuildStep::IosBuildStep(BuildStepList *parent) :
AbstractProcessStep(parent, IOS_BUILD_STEP_ID)
IosBuildStep::IosBuildStep(BuildStepList *parent, Id id)
: AbstractProcessStep(parent, id)
{
setDefaultDisplayName(QCoreApplication::translate("GenericProjectManager::Internal::IosBuildStep",
IOS_BUILD_STEP_DISPLAY_NAME));

2
src/plugins/ios/iosbuildstep.h
View File

@@ -45,7 +45,7 @@ class IosBuildStep : public ProjectExplorer::AbstractProcessStep
friend class IosBuildStepFactory;
public:
explicit IosBuildStep(ProjectExplorer::BuildStepList *parent);
IosBuildStep(ProjectExplorer::BuildStepList *parent, Core::Id id);
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;
void setBaseArguments(const QStringList &args);

4
src/plugins/ios/iosdeploystep.cpp
View File

@@ -55,8 +55,8 @@ using namespace Utils;
namespace Ios {
namespace Internal {
IosDeployStep::IosDeployStep(BuildStepList *parent)
: BuildStep(parent, stepId())
IosDeployStep::IosDeployStep(BuildStepList *parent, Core::Id id)
: BuildStep(parent, id)
{
setImmutable(true);
updateDisplayNames();

2
src/plugins/ios/iosdeploystep.h
View File

@@ -50,7 +50,7 @@ public:
};
friend class IosDeployStepFactory;
explicit IosDeployStep(ProjectExplorer::BuildStepList *bc);
IosDeployStep(ProjectExplorer::BuildStepList *bc, Core::Id id);
static Core::Id stepId();
void cleanup();

4
src/plugins/ios/iosdsymbuildstep.cpp
View File

@@ -59,8 +59,8 @@ static const char COMMAND_PARTIAL_KEY[] = ".Command";
static const char ARGUMENTS_PARTIAL_KEY[] = ".Arguments";
static const char CLEAN_PARTIAL_KEY[] = ".Clean";
IosDsymBuildStep::IosDsymBuildStep(BuildStepList *parent) :
AbstractProcessStep(parent, Constants::IOS_DSYM_BUILD_STEP_ID),
IosDsymBuildStep::IosDsymBuildStep(BuildStepList *parent, Id id) :
AbstractProcessStep(parent, id),
m_clean(parent->id() == ProjectExplorer::Constants::BUILDSTEPS_CLEAN)
{
}

2
src/plugins/ios/iosdsymbuildstep.h
View File

@@ -42,7 +42,7 @@ class IosDsymBuildStep : public ProjectExplorer::AbstractProcessStep
friend class IosDsymBuildStepConfigWidget;
public:
IosDsymBuildStep(ProjectExplorer::BuildStepList *parent);
IosDsymBuildStep(ProjectExplorer::BuildStepList *parent, Core::Id id);
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;
void setArguments(const QStringList &args);