feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Pass Id to BuildStep constructor

Browse Source 
Allows to use constants in fewer places, similar to what e.g.
RunConfiguration does.

Change-Id: I9d049128206c4acf0ce14b06b66d6c090a7c5242
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-12-20 17:05:30 +01:00
parent 2f5365bf61
commit c95bde6f6a
73 changed files with 140 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/nim/project/nimblebuildconfiguration.cpp
View File

@@ -26,7 +26,7 @@
#include "nimblebuildconfiguration.h"
#include "nimconstants.h"
#include "nimblebuildstep.h"
//#include "nimblebuildstep.h"
#include "nimbleproject.h"
#include "nimblebuildsystem.h"
@@ -53,23 +53,11 @@ NimbleBuildConfiguration::NimbleBuildConfiguration(Target *target, Core::Id id)
setConfigWidgetDisplayName(tr("General"));
setConfigWidgetHasFrame(true);
setBuildDirectorySettingsKey("Nim.NimbleBuildConfiguration.BuildDirectory");
appendInitialBuildStep(Constants::C_NIMBLEBUILDSTEP_ID);
setInitializer([this](const BuildInfo &info) {
m_buildType = info.buildType;
setBuildDirectory(project()->projectDirectory());
// FIXME: This is the wrong place for this decision, as it depends on
// information that's typically only available after parsing which takes
// the build configuration that is initialized here into account.
// // Don't add a nimble build step when the package has no binaries (i.e a library package)
// m_nimbleBuildSystem = dynamic_cast<NimbleBuildSystem *>(buildSystem());
// if (!m_nimbleBuildSystem->metadata().bin.empty())
// {
buildSteps()->appendStep(new NimbleBuildStep(buildSteps()));
// }
});
}