feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Use QSortFilterProxyModel for TaskFilterModel

Browse Source 
We used our own, hand-rolled filter model implementation for performance
reasons, but benchmarking shows no difference.

Change-Id: I076ffeffbd39b468308d48d23d15a69b966dbc23
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2019-04-04 13:34:37 +02:00
parent 07645527a3
commit c960885733
3 changed files with 18 additions and 191 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/projectexplorer/taskwindow.cpp
View File

@@ -417,7 +417,6 @@ void TaskWindow::loadSettings()
if (value.isValid()) {
bool includeWarnings = value.toBool();
d->m_filter->setFilterIncludesWarnings(includeWarnings);
d->m_filter->setFilterIncludesUnknowns(includeWarnings);
d->m_filterWarningsButton->setDown(d->m_filter->filterIncludesWarnings());
}
}
@@ -536,7 +535,6 @@ void TaskWindow::actionTriggered()
void TaskWindow::setShowWarnings(bool show)
{
d->m_filter->setFilterIncludesWarnings(show);
d->m_filter->setFilterIncludesUnknowns(show); // "Unknowns" are often associated with warnings
}
void TaskWindow::updateCategoriesMenu()