From c96b707cfbcf93724b932dd87e5bd6ca4988831b Mon Sep 17 00:00:00 2001 From: David Schulz Date: Thu, 24 Jan 2019 10:46:53 +0100 Subject: [PATCH] QmlJsEditor: fix completion item order Items with assigned data were preferred over items without data, leading to always preferring some special functions over objects like parent and parentChanged. Change-Id: I69e7e3ee2e80283daa16cd3df0260ebdb9a2b7f9 Fixes: QTCREATORBUG-21527 Reviewed-by: Thomas Hartmann --- src/plugins/qmljseditor/qmljscompletionassist.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/plugins/qmljseditor/qmljscompletionassist.cpp b/src/plugins/qmljseditor/qmljscompletionassist.cpp index 4d7eb0c1ed4..1d0393a950e 100644 --- a/src/plugins/qmljseditor/qmljscompletionassist.cpp +++ b/src/plugins/qmljseditor/qmljscompletionassist.cpp @@ -1026,8 +1026,6 @@ public: return true; else if (b->text().isEmpty()) return false; - else if (a->isValid() != b->isValid()) - return a->isValid(); else if (a->text().at(0).isUpper() && b->text().at(0).isLower()) return false; else if (a->text().at(0).isLower() && b->text().at(0).isUpper())