feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

debugger: Use the 'r' format to read register contents.

Browse Source 
One wart less.

Change-Id: Iff86c93308a4e4d93a55139940aff2e26edc1e1f
Reviewed-on: http://codereview.qt-project.org/4827
Reviewed-by: hjk <qthjk@ovi.com>
This commit is contained in:
hjk
2011-09-13 18:18:22 +02:00
committed by hjk
parent e66a19806e
commit c977df63cb
1 changed files with 4 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -3603,7 +3603,7 @@ void GdbEngine::reloadRegisters()
if (m_gdbAdapter->isCodaAdapter()) {
m_gdbAdapter->codaReloadRegisters();
} else {
postCommand("-data-list-register-values x",
postCommand("-data-list-register-values r",
Discardable, CB(handleRegisterListValues));
}
}
@@ -3646,42 +3646,15 @@ void GdbEngine::handleRegisterListValues(const GdbResponse &response)
return;
Registers registers = registerHandler()->registers();
int registerCount = registers.size();
const int registerCount = registers.size();
// 24^done,register-values=[{number="0",value="0xf423f"},...]
const GdbMi values = response.data.findChild("register-values");
QTC_ASSERT(registerCount == values.children().size(), return);
for (int i = 0; i != registerCount; ++i) {
const GdbMi &item = values.children().at(i);
Register &reg = registers[i];
const GdbMi &item = values.children().at(i);
GdbMi val = item.findChild("value");
QByteArray ba;
if (val.data().startsWith('{')) {
int pos1 = val.data().indexOf("v2_int32");
if (pos1 == -1)
pos1 = val.data().indexOf("v4_int32");
if (pos1 == -1)
pos1 = val.data().indexOf("u32 = {");
if (pos1 != -1) {
// FIXME: This block wastes cycles.
pos1 = val.data().indexOf('{', pos1 + 1) + 1;
int pos2 = val.data().indexOf('}', pos1);
QByteArray ba2 = val.data().mid(pos1, pos2 - pos1);
foreach (QByteArray ba3, ba2.split(',')) {
ba3 = ba3.trimmed();
QTC_ASSERT(ba3.size() >= 3, continue);
QTC_ASSERT(ba3.size() <= 10, continue);
ba.prepend(QByteArray(10 - ba3.size(), '0'));
ba.prepend(ba3.mid(2));
}
ba.prepend("0x");
reg.value = _(ba);
} else {
reg.value = _(val.data());
}
} else {
reg.value = _(val.data());
}
registers[i].value = _(val.data());
}
registerHandler()->setAndMarkRegisters(registers);
}