debugger: merge a few #ifdef Q_OS_WIN's

This commit is contained in:
hjk
2011-02-17 15:21:35 +01:00
parent 0639d60fc9
commit c9826c1b4e
4 changed files with 6 additions and 12 deletions

View File

@@ -37,9 +37,7 @@
#include "abstractgdbprocess.h" #include "abstractgdbprocess.h"
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
#ifdef Q_OS_WIN
#include <utils/qtcprocess.h> #include <utils/qtcprocess.h>
#endif
#include <QtCore/QProcess> #include <QtCore/QProcess>
@@ -82,9 +80,9 @@ bool AbstractGdbAdapter::isTrkAdapter() const
return false; return false;
} }
#ifdef Q_OS_WIN bool AbstractGdbAdapter::prepareCommand()
bool AbstractGdbAdapter::prepareWinCommand()
{ {
#ifdef Q_OS_WIN
Utils::QtcProcess::SplitError perr; Utils::QtcProcess::SplitError perr;
startParameters().processArgs = Utils::QtcProcess::prepareArgs( startParameters().processArgs = Utils::QtcProcess::prepareArgs(
startParameters().processArgs, &perr, startParameters().processArgs, &perr,
@@ -96,9 +94,9 @@ bool AbstractGdbAdapter::prepareWinCommand()
"Debugging complex command lines is currently not supported under Windows"), QString()); "Debugging complex command lines is currently not supported under Windows"), QString());
return false; return false;
} }
#endif
return true; return true;
} }
#endif
QString AbstractGdbAdapter::msgGdbStopFailed(const QString &why) QString AbstractGdbAdapter::msgGdbStopFailed(const QString &why)
{ {

View File

@@ -102,9 +102,7 @@ protected:
const DebuggerStartParameters &startParameters() const; const DebuggerStartParameters &startParameters() const;
DebuggerStartParameters &startParameters(); DebuggerStartParameters &startParameters();
void showMessage(const QString &msg, int channel = LogDebug, int timeout = 1); void showMessage(const QString &msg, int channel = LogDebug, int timeout = 1);
#ifdef Q_OS_WIN bool prepareCommand();
bool prepareWinCommand();
#endif
GdbEngine * const m_engine; GdbEngine * const m_engine;
}; };

View File

@@ -77,10 +77,8 @@ void LocalPlainGdbAdapter::startAdapter()
QTC_ASSERT(state() == EngineSetupRequested, qDebug() << state()); QTC_ASSERT(state() == EngineSetupRequested, qDebug() << state());
showMessage(_("TRYING TO START ADAPTER")); showMessage(_("TRYING TO START ADAPTER"));
#ifdef Q_OS_WIN if (!prepareCommand())
if (!prepareWinCommand())
return; return;
#endif
QStringList gdbArgs; QStringList gdbArgs;

View File

@@ -103,7 +103,7 @@ void TermGdbAdapter::startAdapter()
// m_stubProc.blockSignals(false); // m_stubProc.blockSignals(false);
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
if (!prepareWinCommand()) if (!prepareCommand())
return; return;
#endif #endif