Cmake Open Project: Allow opening projects that have cmake errors

Change-Id: I3779fbe3f6409139b3d027f96ad390a174c0ff7f
Task-number: QTCREATORBUG-6903
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Daniel Teske
2015-08-19 17:18:40 +02:00
parent 87b15b4554
commit c9a9f08d0a
2 changed files with 17 additions and 1 deletions

View File

@@ -60,6 +60,7 @@
#include <QSettings>
#include <QStringList>
#include <QApplication>
#include <QCheckBox>
using namespace CMakeProjectManager;
using namespace CMakeProjectManager::Internal;
@@ -470,6 +471,14 @@ void CMakeRunPage::initWidgets()
m_exitCodeLabel->setVisible(false);
fl->addRow(m_exitCodeLabel);
m_continueCheckBox = new QCheckBox(this);
m_continueCheckBox->setVisible(false);
m_continueCheckBox->setText(tr("Open project with errors."));
fl->addRow(m_continueCheckBox);
connect(m_continueCheckBox, &QCheckBox::toggled,
this, &CMakeRunPage::completeChanged);
setTitle(tr("Run CMake"));
setMinimumSize(600, 400);
}
@@ -705,8 +714,10 @@ void CMakeRunPage::cmakeFinished()
m_exitCodeLabel->setText(tr("CMake exited with errors. Please check CMake output."));
static_cast<Utils::HistoryCompleter *>(m_argumentsLineEdit->completer())->removeHistoryItem(0);
m_haveCbpFile = false;
m_continueCheckBox->setVisible(true);
} else {
m_exitCodeLabel->setVisible(false);
m_continueCheckBox->setVisible(false);
m_haveCbpFile = true;
}
m_cmakeProcess->deleteLater();
@@ -726,5 +737,5 @@ void CMakeRunPage::cleanupPage()
bool CMakeRunPage::isComplete() const
{
int index = m_generatorComboBox->currentIndex();
return index != -1 && m_haveCbpFile;
return index != -1 && (m_haveCbpFile || m_continueCheckBox->isChecked());
}