ClangTools: Rename ClangToolsConfigWidget -> SettingsWidget

Change-Id: I37ee3435054b27fd9e990f2923e6246ecb9e631f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
Nikolai Kosjar
2019-08-27 16:09:39 +02:00
parent 1bbdb1440f
commit c9b81d2d39
7 changed files with 23 additions and 25 deletions

View File

@@ -21,7 +21,6 @@ add_qtc_plugin(ClangTools
clangtoolrunner.cpp clangtoolrunner.h clangtoolrunner.cpp clangtoolrunner.h
clangtools_global.h clangtools_global.h
clangtoolsbasicsettings.cpp clangtoolsbasicsettings.h clangtoolsbasicsettings.ui clangtoolsbasicsettings.cpp clangtoolsbasicsettings.h clangtoolsbasicsettings.ui
clangtoolsconfigwidget.cpp clangtoolsconfigwidget.h clangtoolsconfigwidget.ui
clangtoolsconstants.h clangtoolsconstants.h
clangtoolsdiagnostic.cpp clangtoolsdiagnostic.h clangtoolsdiagnostic.cpp clangtoolsdiagnostic.h
clangtoolsdiagnosticmodel.cpp clangtoolsdiagnosticmodel.h clangtoolsdiagnosticmodel.cpp clangtoolsdiagnosticmodel.h
@@ -32,6 +31,7 @@ add_qtc_plugin(ClangTools
clangtoolsprojectsettingswidget.cpp clangtoolsprojectsettingswidget.h clangtoolsprojectsettingswidget.ui clangtoolsprojectsettingswidget.cpp clangtoolsprojectsettingswidget.h clangtoolsprojectsettingswidget.ui
clangtoolssettings.cpp clangtoolssettings.h clangtoolssettings.cpp clangtoolssettings.h
clangtoolsutils.cpp clangtoolsutils.h clangtoolsutils.cpp clangtoolsutils.h
settingswidget.cpp settingswidget.h settingswidget.ui
) )
extend_qtc_plugin(ClangTools extend_qtc_plugin(ClangTools

View File

@@ -34,7 +34,7 @@ SOURCES += \
clangtoolsprojectsettings.cpp \ clangtoolsprojectsettings.cpp \
clangtoolssettings.cpp \ clangtoolssettings.cpp \
clangtoolsutils.cpp \ clangtoolsutils.cpp \
clangtoolsconfigwidget.cpp settingswidget.cpp \
HEADERS += \ HEADERS += \
clangfileinfo.h \ clangfileinfo.h \
@@ -58,13 +58,12 @@ HEADERS += \
clangtoolsprojectsettings.h \ clangtoolsprojectsettings.h \
clangtoolssettings.h \ clangtoolssettings.h \
clangtoolsutils.h \ clangtoolsutils.h \
clangtoolsconfigwidget.h settingswidget.h \
FORMS += \ FORMS += \
clangtoolsprojectsettingswidget.ui \ clangtoolsprojectsettingswidget.ui \
clangtoolsconfigwidget.ui \ clangtoolsbasicsettings.ui \
clangselectablefilesdialog.ui \ settingswidget.ui \
clangtoolsbasicsettings.ui
equals(TEST, 1) { equals(TEST, 1) {
HEADERS += \ HEADERS += \

View File

@@ -53,9 +53,6 @@ QtcPlugin {
"clangtoolsbasicsettings.cpp", "clangtoolsbasicsettings.cpp",
"clangtoolsbasicsettings.h", "clangtoolsbasicsettings.h",
"clangtoolsbasicsettings.ui", "clangtoolsbasicsettings.ui",
"clangtoolsconfigwidget.cpp",
"clangtoolsconfigwidget.h",
"clangtoolsconfigwidget.ui",
"clangtoolsconstants.h", "clangtoolsconstants.h",
"clangtoolsdiagnostic.cpp", "clangtoolsdiagnostic.cpp",
"clangtoolsdiagnostic.h", "clangtoolsdiagnostic.h",
@@ -76,6 +73,9 @@ QtcPlugin {
"clangtoolsutils.h", "clangtoolsutils.h",
"clangtoolsplugin.cpp", "clangtoolsplugin.cpp",
"clangtoolsplugin.h", "clangtoolsplugin.h",
"settingswidget.cpp",
"settingswidget.h",
"settingswidget.ui",
] ]
Group { Group {

View File

@@ -25,11 +25,11 @@
#include "clangtoolsplugin.h" #include "clangtoolsplugin.h"
#include "clangtoolsconfigwidget.h"
#include "clangtoolsconstants.h" #include "clangtoolsconstants.h"
#include "clangtoolsprojectsettingswidget.h" #include "clangtoolsprojectsettingswidget.h"
#include "clangtidyclazytool.h" #include "clangtidyclazytool.h"
#include "clangtoolsprojectsettings.h" #include "clangtoolsprojectsettings.h"
#include "settingswidget.h"
#ifdef WITH_TESTS #ifdef WITH_TESTS
#include "clangtoolspreconfiguredsessiontests.h" #include "clangtoolspreconfiguredsessiontests.h"
@@ -83,7 +83,7 @@ public:
QWidget *widget() override QWidget *widget() override
{ {
if (!m_widget) if (!m_widget)
m_widget = new ClangToolsConfigWidget(ClangToolsSettings::instance()); m_widget = new SettingsWidget(ClangToolsSettings::instance());
return m_widget; return m_widget;
} }

View File

@@ -23,9 +23,10 @@
** **
****************************************************************************/ ****************************************************************************/
#include "clangtoolsconfigwidget.h" #include "settingswidget.h"
#include "ui_clangtoolsbasicsettings.h" #include "ui_clangtoolsbasicsettings.h"
#include "ui_clangtoolsconfigwidget.h" #include "ui_settingswidget.h"
#include "clangtoolsutils.h" #include "clangtoolsutils.h"
@@ -39,11 +40,11 @@
namespace ClangTools { namespace ClangTools {
namespace Internal { namespace Internal {
ClangToolsConfigWidget::ClangToolsConfigWidget( SettingsWidget::SettingsWidget(
ClangToolsSettings *settings, ClangToolsSettings *settings,
QWidget *parent) QWidget *parent)
: QWidget(parent) : QWidget(parent)
, m_ui(new Ui::ClangToolsConfigWidget) , m_ui(new Ui::SettingsWidget)
, m_settings(settings) , m_settings(settings)
{ {
m_ui->setupUi(this); m_ui->setupUi(this);
@@ -83,7 +84,7 @@ ClangToolsConfigWidget::ClangToolsConfigWidget(
}); });
} }
ClangToolsConfigWidget::~ClangToolsConfigWidget() = default; SettingsWidget::~SettingsWidget() = default;
} // namespace Internal } // namespace Internal
} // namespace ClangTools } // namespace ClangTools

View File

@@ -34,19 +34,17 @@
namespace ClangTools { namespace ClangTools {
namespace Internal { namespace Internal {
namespace Ui { class ClangToolsConfigWidget; } namespace Ui { class SettingsWidget; }
class ClangExecutableVersion; class SettingsWidget : public QWidget
class ClangToolsConfigWidget : public QWidget
{ {
Q_OBJECT Q_OBJECT
public: public:
ClangToolsConfigWidget(ClangToolsSettings *settings, QWidget *parent = nullptr); SettingsWidget(ClangToolsSettings *settings, QWidget *parent = nullptr);
~ClangToolsConfigWidget() override; ~SettingsWidget() override;
private: private:
std::unique_ptr<Ui::ClangToolsConfigWidget> m_ui; std::unique_ptr<Ui::SettingsWidget> m_ui;
ClangToolsSettings *m_settings; ClangToolsSettings *m_settings;
}; };

View File

@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<ui version="4.0"> <ui version="4.0">
<class>ClangTools::Internal::ClangToolsConfigWidget</class> <class>ClangTools::Internal::SettingsWidget</class>
<widget class="QWidget" name="ClangTools::Internal::ClangToolsConfigWidget"> <widget class="QWidget" name="ClangTools::Internal::SettingsWidget">
<property name="geometry"> <property name="geometry">
<rect> <rect>
<x>0</x> <x>0</x>