RemoteLinux: Remove Maemo references from generic classes.

Change-Id: Ifba758596c8facd9e34e209e94dd427bbd109f3e
Reviewed-on: http://codereview.qt.nokia.com/2302
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
This commit is contained in:
Christian Kandeler
2011-07-27 18:04:43 +02:00
parent 19ea4da35a
commit c9fda1286a
6 changed files with 19 additions and 17 deletions

View File

@@ -34,7 +34,7 @@
#include "deployablefile.h" #include "deployablefile.h"
#include "deploymentinfo.h" #include "deploymentinfo.h"
#include "genericdirectuploadservice.h" #include "genericdirectuploadservice.h"
#include "qt4maemodeployconfiguration.h" #include "remotelinuxdeployconfiguration.h"
#include <QtCore/QList> #include <QtCore/QList>
#include <QtCore/QSharedPointer> #include <QtCore/QSharedPointer>

View File

@@ -11,7 +11,7 @@
</rect> </rect>
</property> </property>
<property name="windowTitle"> <property name="windowTitle">
<string>Maemo Device Configurations</string> <string>Linux Device Configurations</string>
</property> </property>
<layout class="QHBoxLayout" name="horizontalLayout"> <layout class="QHBoxLayout" name="horizontalLayout">
<item> <item>

View File

@@ -52,16 +52,12 @@ const char MeeGoOsType[] = "MeeGoOsType";
static const QLatin1String MAEMO_RC_ID(PREFIX); static const QLatin1String MAEMO_RC_ID(PREFIX);
static const QLatin1String MAEMO_RC_ID_PREFIX(PREFIX "."); static const QLatin1String MAEMO_RC_ID_PREFIX(PREFIX ".");
static const QLatin1String ArgumentsKey(PREFIX ".Arguments");
static const QLatin1String LastDeployedHostsKey(PREFIX ".LastDeployedHosts"); static const QLatin1String LastDeployedHostsKey(PREFIX ".LastDeployedHosts");
static const QLatin1String LastDeployedFilesKey(PREFIX ".LastDeployedFiles"); static const QLatin1String LastDeployedFilesKey(PREFIX ".LastDeployedFiles");
static const QLatin1String LastDeployedRemotePathsKey(PREFIX ".LastDeployedRemotePaths"); static const QLatin1String LastDeployedRemotePathsKey(PREFIX ".LastDeployedRemotePaths");
static const QLatin1String LastDeployedTimesKey(PREFIX ".LastDeployedTimes"); static const QLatin1String LastDeployedTimesKey(PREFIX ".LastDeployedTimes");
static const QLatin1String ProFileKey(PREFIX ".ProFile");
static const QLatin1String ExportedLocalDirsKey(PREFIX ".ExportedLocalDirs"); static const QLatin1String ExportedLocalDirsKey(PREFIX ".ExportedLocalDirs");
static const QLatin1String RemoteMountPointsKey(PREFIX ".RemoteMountPoints"); static const QLatin1String RemoteMountPointsKey(PREFIX ".RemoteMountPoints");
static const QLatin1String BaseEnvironmentBaseKey(PREFIX ".BaseEnvironmentBase");
static const QLatin1String UserEnvironmentChangesKey(PREFIX ".UserEnvironmentChanges");
} // namespace Internal } // namespace Internal
} // namespace RemoteLinux } // namespace RemoteLinux

View File

@@ -32,14 +32,15 @@
#include "remotelinuxdebugsupport.h" #include "remotelinuxdebugsupport.h"
#include "linuxdeviceconfiguration.h" #include "linuxdeviceconfiguration.h"
#include "qt4maemotarget.h"
#include "remotelinuxapplicationrunner.h" #include "remotelinuxapplicationrunner.h"
#include "remotelinuxusedportsgatherer.h" #include "remotelinuxusedportsgatherer.h"
#include <debugger/debuggerengine.h> #include <debugger/debuggerengine.h>
#include <projectexplorer/abi.h> #include <projectexplorer/abi.h>
#include <projectexplorer/project.h> #include <projectexplorer/project.h>
#include <projectexplorer/target.h>
#include <projectexplorer/toolchain.h> #include <projectexplorer/toolchain.h>
#include <qt4projectmanager/qt4buildconfiguration.h>
#include <utils/qtcassert.h> #include <utils/qtcassert.h>
using namespace Utils; using namespace Utils;

View File

@@ -59,6 +59,13 @@ using namespace Qt4ProjectManager;
namespace RemoteLinux { namespace RemoteLinux {
namespace Internal { namespace Internal {
namespace {
const char ArgumentsKey[] = "Qt4ProjectManager.MaemoRunConfiguration.Arguments";
const char ProFileKey[] = "Qt4ProjectManager.MaemoRunConfiguration.ProFile";
const char BaseEnvironmentBaseKey[] = "Qt4ProjectManager.MaemoRunConfiguration.BaseEnvironmentBase";
const char UserEnvironmentChangesKey[]
= "Qt4ProjectManager.MaemoRunConfiguration.UserEnvironmentChanges";
} // anonymous namespace
class RemoteLinuxRunConfigurationPrivate { class RemoteLinuxRunConfigurationPrivate {
public: public:
@@ -200,11 +207,11 @@ void RemoteLinuxRunConfiguration::proFileUpdate(Qt4ProjectManager::Qt4ProFileNod
QVariantMap RemoteLinuxRunConfiguration::toMap() const QVariantMap RemoteLinuxRunConfiguration::toMap() const
{ {
QVariantMap map(RunConfiguration::toMap()); QVariantMap map(RunConfiguration::toMap());
map.insert(ArgumentsKey, m_d->arguments); map.insert(QLatin1String(ArgumentsKey), m_d->arguments);
const QDir dir = QDir(target()->project()->projectDirectory()); const QDir dir = QDir(target()->project()->projectDirectory());
map.insert(ProFileKey, dir.relativeFilePath(m_d->proFilePath)); map.insert(QLatin1String(ProFileKey), dir.relativeFilePath(m_d->proFilePath));
map.insert(BaseEnvironmentBaseKey, m_d->baseEnvironmentType); map.insert(QLatin1String(BaseEnvironmentBaseKey), m_d->baseEnvironmentType);
map.insert(UserEnvironmentChangesKey, map.insert(QLatin1String(UserEnvironmentChangesKey),
Utils::EnvironmentItem::toStringList(m_d->userEnvironmentChanges)); Utils::EnvironmentItem::toStringList(m_d->userEnvironmentChanges));
return map; return map;
} }
@@ -214,13 +221,13 @@ bool RemoteLinuxRunConfiguration::fromMap(const QVariantMap &map)
if (!RunConfiguration::fromMap(map)) if (!RunConfiguration::fromMap(map))
return false; return false;
m_d->arguments = map.value(ArgumentsKey).toString(); m_d->arguments = map.value(QLatin1String(ArgumentsKey)).toString();
const QDir dir = QDir(target()->project()->projectDirectory()); const QDir dir = QDir(target()->project()->projectDirectory());
m_d->proFilePath = dir.filePath(map.value(ProFileKey).toString()); m_d->proFilePath = dir.filePath(map.value(QLatin1String(ProFileKey)).toString());
m_d->userEnvironmentChanges = m_d->userEnvironmentChanges =
Utils::EnvironmentItem::fromStringList(map.value(UserEnvironmentChangesKey) Utils::EnvironmentItem::fromStringList(map.value(QLatin1String(UserEnvironmentChangesKey))
.toStringList()); .toStringList());
m_d->baseEnvironmentType = static_cast<BaseEnvironmentType> (map.value(BaseEnvironmentBaseKey, m_d->baseEnvironmentType = static_cast<BaseEnvironmentType>(map.value(QLatin1String(BaseEnvironmentBaseKey),
SystemBaseEnvironment).toInt()); SystemBaseEnvironment).toInt());
m_d->validParse = qt4Target()->qt4Project()->validParse(m_d->proFilePath); m_d->validParse = qt4Target()->qt4Project()->validParse(m_d->proFilePath);

View File

@@ -33,7 +33,6 @@
#ifndef REMOTELINUXRUNCONFIGURATION_H #ifndef REMOTELINUXRUNCONFIGURATION_H
#define REMOTELINUXRUNCONFIGURATION_H #define REMOTELINUXRUNCONFIGURATION_H
#include "maemoconstants.h"
#include "portlist.h" #include "portlist.h"
#include "remotelinux_export.h" #include "remotelinux_export.h"
@@ -59,7 +58,6 @@ class RemoteLinuxRunConfigurationWidget;
class RemoteLinuxDeployConfiguration; class RemoteLinuxDeployConfiguration;
namespace Internal { namespace Internal {
class MaemoDeviceConfigListModel;
class RemoteLinuxRunConfigurationPrivate; class RemoteLinuxRunConfigurationPrivate;
class RemoteLinuxRunConfigurationFactory; class RemoteLinuxRunConfigurationFactory;
} // namespace Internal } // namespace Internal