From ca5ed8879fc4b3bb2f4868e44eacbc020f150b7b Mon Sep 17 00:00:00 2001 From: hjk Date: Mon, 25 Nov 2019 13:07:31 +0100 Subject: [PATCH] ProjectExplorer: Use new RC update indirection for DesktopRunConfig This is a minimal-invasive change, one can imagine inlining the updateTargetInformation code in the ctor, even with direct access to the aspects created there. Change-Id: Ic43fe538dec33d24ad72bc651e7775e1760b2db2 Reviewed-by: Christian Kandeler --- src/plugins/projectexplorer/desktoprunconfiguration.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/plugins/projectexplorer/desktoprunconfiguration.cpp b/src/plugins/projectexplorer/desktoprunconfiguration.cpp index 070bb23ce0c..74e5164ec34 100644 --- a/src/plugins/projectexplorer/desktoprunconfiguration.cpp +++ b/src/plugins/projectexplorer/desktoprunconfiguration.cpp @@ -77,11 +77,13 @@ DesktopRunConfiguration::DesktopRunConfiguration(Target *target, Core::Id id, Ki bti.runEnvModifier(env, libAspect->value()); }); + + setUpdater([this] { updateTargetInformation(); }); + if (kind == Qbs) { // Handles device changes, etc. - connect(target, &Target::kitChanged, - this, &DesktopRunConfiguration::updateTargetInformation); + connect(target, &Target::kitChanged, this, &RunConfiguration::update); } else if (m_kind == CMake) { @@ -89,8 +91,7 @@ DesktopRunConfiguration::DesktopRunConfiguration(Target *target, Core::Id id, Ki } - connect(target, &Target::buildSystemUpdated, - this, &DesktopRunConfiguration::updateTargetInformation); + connect(target, &Target::buildSystemUpdated, this, &RunConfiguration::update); } void DesktopRunConfiguration::updateTargetInformation()