feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

WebAssembly: Prevent null pointer access

Browse Source 
The detector.device can be nullptr

Amends: cacc4aeede

Change-Id: I5b9b6aa722c8e6e8a96d05cdf2f1b214735db858
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Alessandro Portale
2023-05-17 17:24:28 +02:00
parent 7057962e44
commit caad8074de
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/webassembly/webassemblytoolchain.cpp
View File

@@ -96,7 +96,8 @@ static Toolchains doAutoDetect(const ToolchainDetector &detector)
if (!WebAssemblyEmSdk::isValid(sdk)) if (!WebAssemblyEmSdk::isValid(sdk))
return {}; return {};
if (detector.device->type() != ProjectExplorer::Constants::DESKTOP_DEVICE_TYPE) { if (detector.device
&& detector.device->type() != ProjectExplorer::Constants::DESKTOP_DEVICE_TYPE) {
// Only detect toolchains from the emsdk installation device // Only detect toolchains from the emsdk installation device
const FilePath deviceRoot = detector.device->rootPath(); const FilePath deviceRoot = detector.device->rootPath();
if (deviceRoot.host() != sdk.host()) if (deviceRoot.host() != sdk.host())