From cae7b16a9020a901182b695257c41fe2b1f1b7da Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Wed, 15 Apr 2020 13:33:44 +0200 Subject: [PATCH] AutoTest: Avoid possible nullptr access Fixes a crash when loading qtdeclarative and parsing for Qt Quick tests. Fixes: QTCREATORBUG-23864 Change-Id: I0c88908f578e2dd92341a6fdd427aed5157bb94b Reviewed-by: David Schulz Reviewed-by: Richard Weickelt --- src/plugins/autotest/quick/quicktestvisitors.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/autotest/quick/quicktestvisitors.cpp b/src/plugins/autotest/quick/quicktestvisitors.cpp index 598b16afec7..0b6548131e8 100644 --- a/src/plugins/autotest/quick/quicktestvisitors.cpp +++ b/src/plugins/autotest/quick/quicktestvisitors.cpp @@ -212,6 +212,8 @@ bool QuickTestAstVisitor::visit(CPlusPlus::CallAST *ast) if (expressionListAST && expressionListAST->value) { const auto *stringLitAST = expressionListAST->value->asStringLiteral(); + if (!stringLitAST) + return false; const auto *string = translationUnit()->stringLiteral(stringLitAST->literal_token); if (string) {