feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Mark method as static

Browse Source 
Change-Id: I14f2f0acf266a0fb4f88e26f50cfbe2257e3ab9a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Bernhard Beschow
2021-01-26 13:50:54 +01:00
parent 784de5fb6c
commit cba4d5de5c
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/autotest/testtreemodel.cpp
View File

@@ -213,11 +213,11 @@ QList<ITestConfiguration *> TestTreeModel::getTestsForFile(const Utils::FilePath
return result; return result;
} }
QList<TestTreeItem *> TestTreeModel::testItemsByName(TestTreeItem *root, const QString &testName) static QList<TestTreeItem *> testItemsByName(TestTreeItem *root, const QString &testName)
{ {
QList<TestTreeItem *> result; QList<TestTreeItem *> result;
root->forFirstLevelChildItems([&testName, &result, this](TestTreeItem *node) { root->forFirstLevelChildItems([&testName, &result](TestTreeItem *node) {
if (node->type() == TestTreeItem::TestSuite || node->type() == TestTreeItem::TestCase) { if (node->type() == TestTreeItem::TestSuite || node->type() == TestTreeItem::TestCase) {
if (node->name() == testName) { if (node->name() == testName) {
result << node; result << node;
@@ -299,7 +299,7 @@ QList<TestTreeItem *> TestTreeModel::testItemsByName(const QString &testName)
{ {
QList<TestTreeItem *> result; QList<TestTreeItem *> result;
for (TestTreeItem *frameworkRoot : frameworkRootNodes()) for (TestTreeItem *frameworkRoot : frameworkRootNodes())
result << testItemsByName(frameworkRoot, testName); result << Autotest::testItemsByName(frameworkRoot, testName);
return result; return result;
} }

1
src/plugins/autotest/testtreemodel.h
View File

@@ -111,7 +111,6 @@ private:
void revalidateCheckState(ITestTreeItem *item); void revalidateCheckState(ITestTreeItem *item);
void setupParsingConnections(); void setupParsingConnections();
void filterAndInsert(TestTreeItem *item, TestTreeItem *root, bool groupingEnabled); void filterAndInsert(TestTreeItem *item, TestTreeItem *root, bool groupingEnabled);
QList<TestTreeItem *> testItemsByName(TestTreeItem *root, const QString &testName);
void onTargetChanged(ProjectExplorer::Target *target); void onTargetChanged(ProjectExplorer::Target *target);
void onBuildSystemTestsUpdated(); void onBuildSystemTestsUpdated();
const QList<TestTreeItem *> frameworkRootNodes() const; const QList<TestTreeItem *> frameworkRootNodes() const;