feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Merge SimpleBuildStepWidget into BuildStepWidget

Browse Source 
The extra m_step member is not worth the abstraction, especially
since almost all non-SimpleBuildStepWidget have something similar,
too. Also, as several derived classes needed to correct
SimpleBuildStepWidget's setShowWidget(false).

Change-Id: I6e80d8c84c363b90dc27c70abd7fa6cefa1ed91e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-09-20 11:19:41 +02:00
parent 51562b55e4
commit cbb98bedcf
29 changed files with 59 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/android/androidbuildapkwidget.cpp
View File

@@ -57,7 +57,7 @@ namespace Android {
namespace Internal {
AndroidBuildApkInnerWidget::AndroidBuildApkInnerWidget(AndroidBuildApkStep *step)
: ProjectExplorer::BuildStepConfigWidget(),
: ProjectExplorer::BuildStepConfigWidget(step),
m_ui(new Ui::AndroidBuildApkWidget),
m_step(step)
{
@@ -230,6 +230,7 @@ void AndroidBuildApkInnerWidget::updateSigningWarning()
// AndroidBuildApkWidget
AndroidBuildApkWidget::AndroidBuildApkWidget(AndroidBuildApkStep *step) :
BuildStepConfigWidget(step),
m_step(step)
{
m_extraLibraryListModel = new AndroidExtraLibraryListModel(m_step->target(), this);