feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Merge SimpleBuildStepWidget into BuildStepWidget

Browse Source 
The extra m_step member is not worth the abstraction, especially
since almost all non-SimpleBuildStepWidget have something similar,
too. Also, as several derived classes needed to correct
SimpleBuildStepWidget's setShowWidget(false).

Change-Id: I6e80d8c84c363b90dc27c70abd7fa6cefa1ed91e
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-09-20 11:19:41 +02:00
parent 51562b55e4
commit cbb98bedcf
29 changed files with 59 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/qbsprojectmanager/qbsbuildstep.cpp
View File

@@ -534,6 +534,7 @@ QbsProject *QbsBuildStep::qbsProject() const
// --------------------------------------------------------------------
QbsBuildStepConfigWidget::QbsBuildStepConfigWidget(QbsBuildStep *step) :
BuildStepConfigWidget(step),
m_step(step),
m_ignoreChange(false)
{

2
src/plugins/qbsprojectmanager/qbscleanstep.cpp
View File

@@ -220,7 +220,7 @@ void QbsCleanStep::setMaxJobs(int jobcount)
// --------------------------------------------------------------------
QbsCleanStepConfigWidget::QbsCleanStepConfigWidget(QbsCleanStep *step) :
m_step(step)
BuildStepConfigWidget(step), m_step(step)
{
connect(m_step, &ProjectExplorer::ProjectConfiguration::displayNameChanged,
this, &QbsCleanStepConfigWidget::updateState);

2
src/plugins/qbsprojectmanager/qbsinstallstep.cpp
View File

@@ -251,7 +251,7 @@ void QbsInstallStep::handleBuildConfigChanged()
// --------------------------------------------------------------------
QbsInstallStepConfigWidget::QbsInstallStepConfigWidget(QbsInstallStep *step) :
m_step(step), m_ignoreChange(false)
BuildStepConfigWidget(step), m_step(step), m_ignoreChange(false)
{
connect(m_step, &ProjectExplorer::ProjectConfiguration::displayNameChanged,
this, &QbsInstallStepConfigWidget::updateState);