From cbda4d7b9f55dfeaa66955876dbd0995134233b9 Mon Sep 17 00:00:00 2001 From: Andre Hartmann Date: Thu, 8 Nov 2018 11:58:22 +0100 Subject: [PATCH] ExternalToolsFilter: Modernize with range-based for Change-Id: I69b8ff34c945cf64a99e6b42bd73bc81fed4841e Reviewed-by: Eike Ziller --- src/plugins/coreplugin/locator/externaltoolsfilter.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/plugins/coreplugin/locator/externaltoolsfilter.cpp b/src/plugins/coreplugin/locator/externaltoolsfilter.cpp index 0a96cf1c040..1040e4dc34d 100644 --- a/src/plugins/coreplugin/locator/externaltoolsfilter.cpp +++ b/src/plugins/coreplugin/locator/externaltoolsfilter.cpp @@ -70,10 +70,7 @@ void ExternalToolsFilter::prepareSearch(const QString &entry) m_results.clear(); const Qt::CaseSensitivity entryCaseSensitivity = caseSensitivity(entry); const QMap externalToolsById = ExternalToolManager::toolsById(); - auto end = externalToolsById.cend(); - for (auto it = externalToolsById.cbegin(); it != end; ++it) { - ExternalTool *tool = *it; - + for (ExternalTool *tool : externalToolsById) { int index = tool->displayName().indexOf(entry, 0, entryCaseSensitivity); LocatorFilterEntry::HighlightInfo::DataType hDataType = LocatorFilterEntry::HighlightInfo::DisplayName; if (index < 0) {