feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

BinEditor: Don't register editor factory in global object pool

Browse Source 
Only the service factory is needed.

Change-Id: I40840d6948075f8656eb0cf7113fcc6b95b8f037
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2024-07-30 18:01:47 +02:00
parent 6ef00a1fd6
commit cbe503a904
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/bineditor/bineditorplugin.cpp
View File

@@ -2352,7 +2352,7 @@ static BinEditorFactoryService &binEditorService()
///////////////////////////////// BinEditorFactory ////////////////////////////////// ///////////////////////////////// BinEditorFactory //////////////////////////////////
class BinEditorFactory final : public QObject, public IEditorFactory class BinEditorFactory final : public IEditorFactory
{ {
public: public:
BinEditorFactory() BinEditorFactory()
@@ -2367,13 +2367,11 @@ public:
} }
}; };
static BinEditorFactory &binEditorFactory() void setupBinEditor()
{ {
static BinEditorFactory theBinEditorFactory; static BinEditorFactory theBinEditorFactory;
return theBinEditorFactory;
} }
///////////////////////////////// BinEditorPlugin ////////////////////////////////// ///////////////////////////////// BinEditorPlugin //////////////////////////////////
class BinEditorPlugin final : public ExtensionSystem::IPlugin class BinEditorPlugin final : public ExtensionSystem::IPlugin
@@ -2384,13 +2382,12 @@ class BinEditorPlugin final : public ExtensionSystem::IPlugin
~BinEditorPlugin() final ~BinEditorPlugin() final
{ {
ExtensionSystem::PluginManager::removeObject(&binEditorService()); ExtensionSystem::PluginManager::removeObject(&binEditorService());
ExtensionSystem::PluginManager::removeObject(&binEditorFactory());
} }
void initialize() final void initialize() final
{ {
setupBinEditor();
ExtensionSystem::PluginManager::addObject(&binEditorService()); ExtensionSystem::PluginManager::addObject(&binEditorService());
ExtensionSystem::PluginManager::addObject(&binEditorFactory());
} }
}; };