From cc05c1637778db8210ea901b8da71aeef1bde05e Mon Sep 17 00:00:00 2001 From: Cristian Adam Date: Tue, 25 Jun 2024 15:28:02 +0200 Subject: [PATCH] CMakePM: Ask for a build configuration name for new configurations Amends f866b03b191299e5d5cde11cdad905a90b94bf26 This would do what the QMake build system does on new build types, it asks for a name and uses that name in the build directory. Fixes: QTCREATORBUG-26066 Change-Id: Iec5b4ace1e203affad718b42ec2bcbbc87aef51f Reviewed-by: Alessandro Portale Reviewed-by: Artem Sokolovskii --- src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp b/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp index fed2112822e..178c2a68bfa 100644 --- a/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp +++ b/src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp @@ -1585,7 +1585,7 @@ CMakeBuildConfiguration::CMakeBuildConfiguration(Target *target, Id id) if (info.buildDirectory.isEmpty()) { setBuildDirectory(shadowBuildDirectory(target->project()->projectFilePath(), k, - info.typeName, + info.displayName, info.buildType)); } @@ -1960,6 +1960,9 @@ CMakeBuildConfigurationFactory::CMakeBuildConfigurationFactory() k, info.typeName, info.buildType); + } else { + info.displayName.clear(); // ask for a name + info.buildDirectory.clear(); // This depends on the displayName } result << info; }