feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CoPilot: Fix leak in authwidget

Browse Source 
Also fixes a crash when the state check returns after the widget
was already deleted.

Change-Id: I04256e6ba686469f18ebdb75c73e12cecf330bed
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Marcus Tillmanns
2023-04-24 13:09:44 +02:00
parent e58dd4381f
commit cc14eaf570
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/copilot/authwidget.cpp
View File

@@ -48,6 +48,12 @@ AuthWidget::AuthWidget(QWidget *parent)
}); });
} }
AuthWidget::~AuthWidget()
{
if (m_client)
LanguageClientManager::shutdownClient(m_client);
}
void AuthWidget::setState(const QString &buttonText, bool working) void AuthWidget::setState(const QString &buttonText, bool working)
{ {
m_button->setText(buttonText); m_button->setText(buttonText);

2
src/plugins/copilot/authwidget.h
View File

@@ -25,6 +25,8 @@ class AuthWidget : public QWidget
public: public:
explicit AuthWidget(QWidget *parent = nullptr); explicit AuthWidget(QWidget *parent = nullptr);
~AuthWidget() override;
void updateClient(const Utils::FilePath &nodeJs, const Utils::FilePath &agent); void updateClient(const Utils::FilePath &nodeJs, const Utils::FilePath &agent);
private: private: