feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Simplify the popping code

Browse Source 
It looks like runControl()->showOutputPane() is a good equivalent
to the hack with an introspection of the AppOutputPane object.

Change-Id: I6c4fe3bf2a797eac9ac454140bf78bb2eb278129
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2025-02-19 17:32:47 +01:00
parent 7a055e163d
commit cc4bf69d67
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/valgrind/valgrindengine.cpp
View File

@@ -7,12 +7,9 @@
#include "valgrindtr.h" #include "valgrindtr.h"
#include <coreplugin/icore.h> #include <coreplugin/icore.h>
#include <coreplugin/ioutputpane.h>
#include <coreplugin/progressmanager/futureprogress.h> #include <coreplugin/progressmanager/futureprogress.h>
#include <coreplugin/progressmanager/progressmanager.h> #include <coreplugin/progressmanager/progressmanager.h>
#include <extensionsystem/pluginmanager.h>
#include <projectexplorer/devicesupport/devicekitaspects.h> #include <projectexplorer/devicesupport/devicekitaspects.h>
#include <projectexplorer/devicesupport/idevice.h> #include <projectexplorer/devicesupport/idevice.h>
#include <projectexplorer/projectexplorericons.h> #include <projectexplorer/projectexplorericons.h>
@@ -140,10 +137,7 @@ void ValgrindToolRunner::receiveProcessError(const QString &errorString, Process
default: default:
break; break;
} }
runControl()->showOutputPane();
QObject *obj = ExtensionSystem::PluginManager::getObjectByName("AppOutputPane");
if (auto pane = qobject_cast<IOutputPane *>(obj))
pane->popup(IOutputPane::NoModeSwitch);
} }
} // Valgrid::Internal } // Valgrid::Internal