From cc64529fc4af97028a7fb195fc95a33fc9671f54 Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Fri, 6 Jun 2014 15:25:55 +0200 Subject: [PATCH] CodePaster: Do not crash in case of invalid default protocol Task-number: QTCREATORBUG-12364 Change-Id: I6e9bf75dd6b8df187a6802e9d90c3d986cc86a5c Reviewed-by: Friedemann Kleint --- src/plugins/cpaster/pasteview.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/plugins/cpaster/pasteview.cpp b/src/plugins/cpaster/pasteview.cpp index 47a656984f3..d196f66040c 100644 --- a/src/plugins/cpaster/pasteview.cpp +++ b/src/plugins/cpaster/pasteview.cpp @@ -31,6 +31,7 @@ #include "protocol.h" #include +#include #include #include @@ -112,6 +113,7 @@ void PasteView::contentChanged() void PasteView::protocolChanged(int p) { + QTC_ASSERT(p >= 0 && p < m_protocols.size(), return); const unsigned caps = m_protocols.at(p)->capabilities(); m_ui.uiDescription->setEnabled(caps & Protocol::PostDescriptionCapability); m_ui.uiUsername->setEnabled(caps & Protocol::PostUserNameCapability); @@ -215,6 +217,8 @@ void PasteView::accept() void PasteView::setProtocol(const QString &protocol) { const int index = m_ui.protocolBox->findText(protocol); + if (index < 0) + return; m_ui.protocolBox->setCurrentIndex(index); if (index == m_ui.protocolBox->currentIndex()) protocolChanged(index); // Force enabling