From ccb4619238f54b4ab3a567b92f1fe54e51389797 Mon Sep 17 00:00:00 2001 From: Andre Hartmann Date: Wed, 12 Feb 2025 20:56:38 +0100 Subject: [PATCH] CVS: Fix log for project and repository When the parameter file is empty, the string list passed to runCvs() contained `log ''` which fails. What we really want to run here is simply `log`. Change-Id: I1e76809a37d1fd6247cddc8040fb76ddf72936d2 Reviewed-by: Orgad Shaneh --- src/plugins/cvs/cvsplugin.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/plugins/cvs/cvsplugin.cpp b/src/plugins/cvs/cvsplugin.cpp index 0b41d3854ed..075ca057d4e 100644 --- a/src/plugins/cvs/cvsplugin.cpp +++ b/src/plugins/cvs/cvsplugin.cpp @@ -944,7 +944,10 @@ void CvsPluginPrivate::filelog(const FilePath &workingDir, // no need for temp file const QString id = VcsBaseEditor::getTitleId(workingDir, QStringList(file)); const FilePath source = VcsBaseEditor::getSource(workingDir, file); - const auto response = runCvs(workingDir, {"log", file}, RunFlags::None, codec); + QStringList args = {"log"}; + if (!file.isEmpty()) + args.append(file); + const auto response = runCvs(workingDir, args, RunFlags::None, codec); if (response.result() != ProcessResult::FinishedWithSuccess) return;